Port 'Placeholder' to v3

[garry.yao]

Placeholder is one FCKEditor 2.x plugin that introduce a way to present none-editable content in wysiwyg mode, similar with 'fakeobject' but allow dynamic content.

[garry.yao]

Let's update the menu icon, and for plugins that does not get into core, we need a sample page for it.

[fredck]

This is the typical case of "pure plugin" implementation, so let's leave the lang entries into the plugin directory as well.

[garry.yao]

The way of how plugin language files loaded is wrong, the plugin system has already 'well established' infrastructure for load lang files, check 'uicolor' as an example.

Besides, double-click should simply opens the placeholder dialog.

[garry.yao]

The 'doubleclick' processing is too simple that it doesn't fill up dialog correctly, in additional, please use the following lines as sample content:

<p>This is a [[sample placeholder]]. You are using <a href="http://ckeditor.com/">CKEditor</a>. </p>

[Saare]

The problem in fact was the detection of the element in the dialog.

[garry.yao]

I think the 'onShow' logic is over complicated, how about:

				if ( isEdit )
				{
					var range = editor.getSelection().getRanges()[0];
					range.shrink( CKEDITOR.SHRINK_TEXT );
					var node = range.startContainer;
					while( node && !( node.type == CKEDITOR.NODE_ELEMENT && node.hasAttributes('_cke_placeholder') ) )
						node = node.getParent();
					this._element = node;
				}

[Saare]

As we talked, there is an unresloved edge case, but we can live with it for now.

[Saare]

Fixed with [6051].

[dinu]

Reopen: accidental global var htmlFilter

plugin.js line 89: dataFilter = dataProcessor && dataProcessor.dataFilter; htmlFilter = dataProcessor && dataProcessor.htmlFilter;

There should be a comma instead of semicolon between them, or htmlFilter goes global.

[Saare]

Thanks, fixed as a micro change with [6093].

[dinu]

It's an easy hack to YUI Compiler to dump leaked vars, you could integrate in the build, especially easy since you have very few globals.

[fredck]

Replying to dinu:

It's an easy hack to YUI Compiler to dump leaked vars, you could integrate in the build, especially easy since you have very few globals.

We use JavaScript Lint every once in a while, and always before producing releases. So this thing would get fixed. Thanks for the tip anyway.