Opened 6 years ago

Closed 6 years ago

#5689 closed Bug (fixed)

Adjustments for WriteArea

Reported by: alfonsoml Owned by: alfonsoml
Priority: Normal Milestone: CKEditor 3.4
Component: General Version:
Keywords: Cc:

Description

In order to port WriteArea to use CKEditor some minor adjustments are needed.

The first one might also help in other environments if access to document.domain is restricted, the second one should affect only code running in the Firefox chrome.

Attachments (1)

5689.patch (1.3 KB) - added by alfonsoml 6 years ago.
Proposed patch

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by alfonsoml

Proposed patch

comment:1 Changed 6 years ago by garry.yao

  • Keywords Review- added; Review? removed
  • Resolution set to invalid
  • Status changed from new to closed

We'd use adapter instead of modifying core codes for non-browser compatibility, e.g. Mozilla application, Adobe AIR, ActiveX Objects.

comment:2 Changed 6 years ago by fredck

  • Keywords Confirmed Review? added; Review- removed
  • Resolution invalid deleted
  • Status changed from closed to reopened

I understand the reason behind Garry's comments, but in this case the changes are so minimal that we could take it in consideration. We must just be sure the changes on isCustomDomain will not break anything.

comment:3 Changed 6 years ago by fredck

  • Keywords Confirmed removed
  • Status changed from reopened to confirmed

comment:4 Changed 6 years ago by wwalc

  • Keywords Review? removed
  • Owner changed from alfonsoml to wwalc
  • Status changed from confirmed to review

comment:5 Changed 6 years ago by Saare

  • Status changed from review to review_passed

Please be sure to add proper comments on L326 and L343 and fix the coding style issues on L327 and L344 before commiting.

comment:6 Changed 6 years ago by alfonsoml

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [5752]

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy