Ticket #5715 (closed Bug: fixed)

Opened 5 years ago

Last modified 4 years ago

Cell color picker dialog returns focus to document

Reported by: tobiasz.cudnik Owned by: tobiasz.cudnik
Priority: Normal Milestone: CKEditor 3.4.1
Component: UI : Dialogs Version: 3.1
Keywords: Cc:

Description

Cell color picker dialog returns focus to document.

Reproduce

  1. Use content with some table, eg:
    <table>
    	<tbody>
    		<tr>
    			<td>
    				TD</td>
    		</tr>
    	</tbody>
    </table>
    
  2. Open cell properties dialog (context menu -> Cell -> Cell properties).
  3. Open background/border color picker.
  4. Close second dialog (color picker).
  5. Hit TAB.

Result

  1. Focus is gained by main document and tabbed are page elements.

Expected

  1. Focus goes back to Cell properties dialog.

I'm setting milestone to 3.3 as this may be related to #4649.

Attachments

5715.patch (2.2 KB) - added by brooks 5 years ago.
5715_2.patch (621 bytes) - added by tobiasz.cudnik 4 years ago.

Change History

comment:1 Changed 5 years ago by fredck

  • Milestone set to CKEditor 3.4

comment:2 Changed 5 years ago by brooks

  • Owner set to brooks
  • Status changed from new to assigned

Changed 5 years ago by brooks

comment:3 Changed 5 years ago by brooks

  • Keywords review? added

comment:4 Changed 5 years ago by fredck

  • Keywords Review? added; review? removed

comment:5 Changed 4 years ago by garry.yao

  • Keywords Confirmed Review- added; Review? removed
  • Version set to 3.1
  • Component changed from General to UI : Dialogs

colorPickerDialog._.parentDialog should be used instead of passing the extra param.

comment:6 Changed 4 years ago by fredck

  • Milestone changed from CKEditor 3.4 to CKEditor 3.5

comment:7 Changed 4 years ago by tobiasz.cudnik

  • Status changed from review_failed to assigned
  • Owner changed from brooks to tobiasz.cudnik

Reowning after Brooks.

Changed 4 years ago by tobiasz.cudnik

comment:8 Changed 4 years ago by tobiasz.cudnik

  • Status changed from assigned to review

Simplified patch.

comment:9 Changed 4 years ago by Saare

  • Status changed from review to review_passed
  • Keywords Confirmed removed

comment:10 Changed 4 years ago by tobiasz.cudnik

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [5845].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy