Opened 6 years ago

Closed 6 years ago

#5755 closed New Feature (fixed)

Configuration option for dialog buttons following OS guidelines.

Reported by: JoeK Owned by: Saare
Priority: Normal Milestone: CKEditor 3.5
Component: UI : Dialogs Version: 3.3
Keywords: IBM Cc: damo, satya_minnekanti@…

Description

When on a MAC the dialog buttons are reversed to match the OS. Can a configuration property be provided to enable/disable this feature?

Original feature ticket

Attachments (2)

5755.patch (2.3 KB) - added by Saare 6 years ago.
5755_2.patch (2.3 KB) - added by Saare 6 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 6 years ago by satya

  • Cc satya_minnekanti@… added

comment:2 Changed 6 years ago by fredck

  • Keywords Confirmed added

Yeah, we could have a new "dialog_buttonsOrder" setting, with possible values: "OS" (default), "ltr" or "rtl".

comment:3 Changed 6 years ago by fredck

  • Milestone CKEditor 3.x deleted

Milestone CKEditor 3.x deleted

comment:4 follow-up: Changed 6 years ago by damo

Can we add this to 3.5?

comment:5 in reply to: ↑ 4 Changed 6 years ago by fredck

  • Milestone set to CKEditor 3.5
  • Version changed from SVN (CKEditor) - OLD to 3.3

Replying to damo:

Can we add this to 3.5?

Should not be a big issue. I'm targeting it for now, for investigation.

comment:6 Changed 6 years ago by Saare

  • Owner set to Saare
  • Status changed from confirmed to assigned

Changed 6 years ago by Saare

comment:7 Changed 6 years ago by Saare

  • Status changed from assigned to review

Changed 6 years ago by Saare

comment:8 Changed 6 years ago by Saare

The buttons are now in reverse order by default for RTL.

comment:9 Changed 6 years ago by garry.yao

  • Status changed from review to review_passed

My mistake Saare, R+ for the first patch instead of the second.

comment:10 Changed 6 years ago by Saare

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [5914].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy