Opened 15 years ago
Closed 15 years ago
#5772 closed Bug (fixed)
[IE] Not all list-style-type values are supported by IE
Reported by: | Joe Kavanagh | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.3.1 |
Component: | Core : Lists | Version: | SVN (CKEditor) - OLD |
Keywords: | IBM Confirmed Review+ | Cc: | Damian Satya Minnekanti |
Description
The list style dialog provides options for armenian, georgian, lower-greek and decimal-leading-zero. These list-style-type values are not supported by any version of IE.
IE does not support the values armenian, decimal-leading-zero, georgian, inherit, lower-greek, lower-latin or upper-latin.
Attachments (5)
Change History (19)
comment:1 Changed 15 years ago by
Milestone: | CKEditor 3.x → CKEditor 3.4 |
---|
Changed 15 years ago by
Attachment: | 5772.patch added |
---|
comment:2 Changed 15 years ago by
Keywords: | Confirmed Review? added |
---|---|
Owner: | set to Garry Yao |
Status: | new → assigned |
comment:3 Changed 15 years ago by
Keywords: | Review+ added; Review? removed |
---|
comment:4 Changed 15 years ago by
Milestone: | CKEditor 3.4 → CKEditor 3.3.1 |
---|
comment:6 follow-up: 7 Changed 15 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
The associated patch does not address the reported issue.
Changed 15 years ago by
Attachment: | api_dialog.html added |
---|
comment:7 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Replying to JoeK:
The associated patch does not address the reported issue.
We're not going to remove those options as they are supported by IE8 and should be degradable in lower IE versions, I've included a sample that demonstrate the customization of the select options if you insist on removing them.
Changed 15 years ago by
Attachment: | ScriptError_5567.png added |
---|
comment:8 Changed 15 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
The real problem here is that in IE, if an unsupported number type is selected a script error is thrown. CKEditor should not allow a script error like this, especially if this is a known issue.
comment:9 Changed 15 years ago by
Keywords: | Review+ removed |
---|---|
Status: | reopened → new |
Changed 15 years ago by
Attachment: | 5772_2.patch added |
---|
comment:10 Changed 15 years ago by
Keywords: | Review? added |
---|---|
Status: | new → assigned |
comment:11 Changed 15 years ago by
Keywords: | Review- added; Review? removed |
---|
The browser check must also consider future IE versions, so the check should be:
if ( CKEDITOR.env.ie && CKEDITOR.env.version > 7 )
Other than that, the negation way the condition has been checked is confusing.
Changed 15 years ago by
Attachment: | 5772_3.patch added |
---|
comment:12 Changed 15 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:13 Changed 15 years ago by
Keywords: | Review+ added; Review? removed |
---|
We're using the W3C allowed CSS values for the list-style property. It's in fact an IE fault to not support them, and those should silently fall into a roman numbered list in that browser, while rendering properly in others.
If you want to remove those items, you'll need to customize the dialog for your needs. But, the fact is that the dialog definition doesn't have an ID for the first dialog page, and so it's not possible to work on it through the API. I'm leaving this ticket opened so it can be fixed.