Opened 7 years ago

Closed 7 years ago

#5772 closed Bug (fixed)

[IE] Not all list-style-type values are supported by IE

Reported by: JoeK Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.3.1
Component: Core : Lists Version: SVN (CKEditor) - OLD
Keywords: IBM Confirmed Review+ Cc: damo satya

Description

The list style dialog provides options for armenian, georgian, lower-greek and decimal-leading-zero. These list-style-type values are not supported by any version of IE.

IE does not support the values armenian, decimal-leading-zero, georgian, inherit, lower-greek, lower-latin or upper-latin.

Attachments (5)

5772.patch (534 bytes) - added by garry.yao 7 years ago.
api_dialog.html (2.9 KB) - added by garry.yao 7 years ago.
ScriptError_5567.png (15.1 KB) - added by damo 7 years ago.
5772_2.patch (2.0 KB) - added by garry.yao 7 years ago.
5772_3.patch (2.0 KB) - added by garry.yao 7 years ago.

Download all attachments as: .zip

Change History (19)

comment:1 Changed 7 years ago by fredck

  • Milestone changed from CKEditor 3.x to CKEditor 3.4

We're using the W3C allowed CSS values for the list-style property. It's in fact an IE fault to not support them, and those should silently fall into a roman numbered list in that browser, while rendering properly in others.

If you want to remove those items, you'll need to customize the dialog for your needs. But, the fact is that the dialog definition doesn't have an ID for the first dialog page, and so it's not possible to work on it through the API. I'm leaving this ticket opened so it can be fixed.

Changed 7 years ago by garry.yao

comment:2 Changed 7 years ago by garry.yao

  • Keywords Confirmed Review? added
  • Owner set to garry.yao
  • Status changed from new to assigned

comment:3 Changed 7 years ago by alfonsoml

  • Keywords Review+ added; Review? removed

comment:4 Changed 7 years ago by fredck

  • Milestone changed from CKEditor 3.4 to CKEditor 3.3.1

comment:5 Changed 7 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [5561].

comment:6 follow-up: Changed 7 years ago by JoeK

  • Resolution fixed deleted
  • Status changed from closed to reopened

The associated patch does not address the reported issue.

Changed 7 years ago by garry.yao

comment:7 in reply to: ↑ 6 Changed 7 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from reopened to closed

Replying to JoeK:

The associated patch does not address the reported issue.

We're not going to remove those options as they are supported by IE8 and should be degradable in lower IE versions, I've included a sample that demonstrate the customization of the select options if you insist on removing them.

Changed 7 years ago by damo

comment:8 Changed 7 years ago by damo

  • Resolution fixed deleted
  • Status changed from closed to reopened

The real problem here is that in IE, if an unsupported number type is selected a script error is thrown. CKEditor should not allow a script error like this, especially if this is a known issue.

comment:9 Changed 7 years ago by garry.yao

  • Keywords Review+ removed
  • Status changed from reopened to new

Changed 7 years ago by garry.yao

comment:10 Changed 7 years ago by garry.yao

  • Keywords Review? added
  • Status changed from new to assigned

comment:11 Changed 7 years ago by fredck

  • Keywords Review- added; Review? removed

The browser check must also consider future IE versions, so the check should be:

if ( CKEDITOR.env.ie && CKEDITOR.env.version > 7 )

Other than that, the negation way the condition has been checked is confusing.

Changed 7 years ago by garry.yao

comment:12 Changed 7 years ago by garry.yao

  • Keywords Review? added; Review- removed

comment:13 Changed 7 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:14 Changed 7 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [5579].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy