Opened 7 years ago

Closed 7 years ago

#5794 closed Bug (fixed)

Second search with no result leads to a JS error

Reported by: Saare Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.3.1
Component: General Version: 3.2.2
Keywords: Confirmed Review+ Cc:

Description

Steps to reproduce

  • Load a sample or the demo.
  • Search for something that does not exist, twice.

Notice that there is an error: startNode is null; _source/core/dom/range.js L1386.
Regression of 3.2.2.

Attachments (2)

5794.patch (1.2 KB) - added by Saare 7 years ago.
5794_2.patch (640 bytes) - added by garry.yao 7 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 7 years ago by Saare

  • Keywords HasPatch added

Regression of [5463].

Changed 7 years ago by Saare

comment:2 Changed 7 years ago by garry.yao

  • Keywords Confirmed Review? added; HasPatch removed
  • Owner set to garry.yao
  • Status changed from new to assigned

The regression is correct, while let's place the fix to the actual bug as range::setStart doesn't suppose to protect against invalid nodes.

Changed 7 years ago by garry.yao

comment:3 Changed 7 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:4 Changed 7 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [5570].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy