Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#5799 closed Bug (fixed)

liststyle plugin doesn't state required plugins

Reported by: alfonsoml Owned by: alfonsoml
Priority: Normal Milestone: CKEditor 3.4
Component: General Version: 3.3
Keywords: Cc:


The liststyle plugin doesn't have a "requires" statement about what plugins it needs, and although it tries to detect the availability of the contextMenu, the editor.addMenuGroup isn't protected.

The code could be changed also to state that the contextmenu is required and remove the "if"s in the code, but I think that this way it can allow for other people for example to create a toolbar button for them even if they disable the contextmenu.

Attachments (1)

5799.patch (1023 bytes) - added by alfonsoml 5 years ago.
Proposed patch

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by alfonsoml

Proposed patch

comment:1 Changed 5 years ago by fredck

  • Milestone set to CKEditor 3.4
  • Status changed from review to review_passed

comment:2 Changed 5 years ago by alfonsoml

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [5732]

comment:3 Changed 5 years ago by fredck

#6095 has been marked as DUP.

Note: See TracTickets for help on using tickets.
© 2003 – 2015 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy