Ticket #5799 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

liststyle plugin doesn't state required plugins

Reported by: alfonsoml Owned by: alfonsoml
Priority: Normal Milestone: CKEditor 3.4
Component: General Version: 3.3
Keywords: Cc:

Description

The liststyle plugin doesn't have a "requires" statement about what plugins it needs, and although it tries to detect the availability of the contextMenu, the editor.addMenuGroup isn't protected.

http://cksource.com/forums/viewtopic.php?f=11&t=18990

The code could be changed also to state that the contextmenu is required and remove the "if"s in the code, but I think that this way it can allow for other people for example to create a toolbar button for them even if they disable the contextmenu.

Attachments

5799.patch (1023 bytes) - added by alfonsoml 4 years ago.
Proposed patch

Change History

Changed 4 years ago by alfonsoml

Proposed patch

comment:1 Changed 4 years ago by fredck

  • Status changed from review to review_passed
  • Milestone set to CKEditor 3.4

comment:2 Changed 4 years ago by alfonsoml

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [5732]

comment:3 Changed 4 years ago by fredck

#6095 has been marked as DUP.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy