Opened 6 years ago

Closed 6 years ago

#5839 closed Bug (fixed)

"Insert row after" removes/moves the ids of the elements from the clicked row.

Reported by: florinc Owned by: mani
Priority: Normal Milestone: CKEditor 3.4.1
Component: General Version: 3.3.1
Keywords: Cc:

Description (last modified by fredck)

When I use in a table the "Insert row after" command the ids of the elements from the clicked row are messed up in two ways:

  1. The ids from table cells or the clicked table row are moved in the new row.
  2. The ids of other elements (I used <input type="text") are removed.

How to reproduce (This is reproduced in FF 3.6.3 and IE 8):

  1. Insert this html in ckeditor:
<table border="1" cellpadding="1" cellspacing="1" style="width: 200px;">
	<tbody>
		<tr id="r1">
			<td id="c1">
				<input type="text" id="i1"/></td>
			<td id="c2">
				<input type="text" id="i2"/></td>
		</tr>
	</tbody>
</table>
  1. Click the only row and insert row after.
  1. Check the source to see that the ids were removed or moved.

Attachments (1)

5839.patch (795 bytes) - added by mani 6 years ago.
Patch

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by fredck

  • Description modified (diff)

comment:2 Changed 6 years ago by fredck

  • Keywords Confirmed added

comment:3 Changed 6 years ago by mani

  • Owner set to mani
  • Status changed from confirmed to assigned

Changed 6 years ago by mani

Patch

comment:4 Changed 6 years ago by mani

  • Status changed from assigned to review

comment:5 Changed 6 years ago by tobiasz.cudnik

  • Status changed from review to review_passed

Please add space in IF statement on L151 when committing, like this:

if (

comment:6 Changed 6 years ago by fredck

  • Milestone set to CKEditor 3.4.1

comment:7 Changed 6 years ago by fredck

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [5884].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy