Ticket #5943 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

Incorrect handling of height and width value in image dialog

Reported by: Saare Owned by: Saare
Priority: Normal Milestone: CKEditor 3.4
Component: General Version: SVN (CKEditor) - OLD
Keywords: Review+ Cc:

Description

Steps to reproduce

  • Open a sample in IE and open the image dialog.
  • Go to the height or width fields, and type a value that ends with percent sign or the 'px' suffix.

An error occurs.

Attachments

5943.patch (942 bytes) - added by Saare 4 years ago.
5943_2.patch (999 bytes) - added by Saare 4 years ago.

Change History

Changed 4 years ago by Saare

comment:1 Changed 4 years ago by Saare

  • Status changed from new to assigned

comment:2 Changed 4 years ago by fredck

  • Keywords Review- added; Review? removed
  • Milestone CKEditor 3.4 deleted

Well... we still need to have the "px" if only a number is provided.

The thing is that the dialog has been created to accept only numbers on the dimension fields. So, if anything is to be done here, we must simply provide validation on those fields.

Changed 4 years ago by Saare

comment:3 Changed 4 years ago by Saare

  • Keywords Review? added; Review- removed
  • Milestone set to CKEditor 3.4

That was my original thought, but looking at the code I realized that there is an intention to accept values with the percent sign and the 'px' suffix. I'm attaching a new patch that adds the 'px' suffix if necessary.

comment:4 Changed 4 years ago by fredck

  • Keywords Review+ added; Review? removed

Ok... that's a good way for it also.

comment:5 Changed 4 years ago by Saare

Fixed [5679].

comment:6 Changed 4 years ago by Saare

  • Status changed from assigned to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy