Ticket #6010 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

Automatic Background Color is Incorrectly displayed as "Black" in UI when it is actually "White"

Reported by: satya Owned by: Saare
Priority: Normal Milestone: CKEditor 3.5
Component: General Version: 3.0
Keywords: IBM Cc: damo,joek

Description

To reproduce the defect

  1. Open Ajax sample.
  1. Enter some text in the Editor,Then click "Background color" menu,select the "Automatic" color.

Problem:

The Automatic color of Background color menu marks black,but it is actually white.

Attachments

6010.patch (2.1 KB) - added by Saare 4 years ago.
6010_1.patch (2.6 KB) - added by Saare 4 years ago.
6010_2.patch (2.5 KB) - added by Saare 4 years ago.

Change History

comment:1 follow-ups: ↓ 2 ↓ 8 Changed 4 years ago by fredck

  • Status changed from new to confirmed

We can try using the document <body> color instead of the black square. Would that be enough?

comment:2 in reply to: ↑ 1 Changed 4 years ago by satya

Replying to fredck:

We can try using the document <body> color instead of the black square. Would that be enough?

I think that should be OK

comment:3 Changed 4 years ago by fredck

  • Milestone set to CKEditor 3.5

comment:4 Changed 4 years ago by Saare

  • Status changed from confirmed to assigned
  • Owner set to Saare

Changed 4 years ago by Saare

comment:5 Changed 4 years ago by Saare

  • Status changed from assigned to review

comment:6 Changed 4 years ago by Saare

  • Version changed from 3.3 to 3.0

comment:7 Changed 4 years ago by fredck

  • Milestone changed from CKEditor 3.4.1 to CKEditor 3.5

comment:8 in reply to: ↑ 1 Changed 4 years ago by garry.yao

  • Status changed from review to review_failed

Replying to fredck:

We can try using the document <body> color instead of the black square. Would that be enough?

It's counter-intuitive to fill with <body> color as the semantic of 'auto' color should be explained instead as 'computed color style of the current element'.

Changed 4 years ago by Saare

comment:9 Changed 4 years ago by Saare

  • Status changed from review_failed to review

comment:10 Changed 4 years ago by garry.yao

  • Status changed from review to review_failed

Fails with the following content when open panel on 'cell2'.

<table style="width: 500px; background-color: #dcdcdc;">
	<tbody>
		<tr>
			<td>
				cell1</td>
			<td bgcolor="#9acd32">
				cell2</td>
		</tr>
	</tbody>
</table>

Please simply use the following to check blocks:

						var path = new CKEDITOR.dom.elementPath( editor.getSelection().getStartElement() );
						block = path.block || path.blockLimit;

Changed 4 years ago by Saare

comment:11 Changed 4 years ago by Saare

  • Status changed from review_failed to review

comment:12 Changed 4 years ago by garry.yao

  • Status changed from review to review_passed

A very informative feature added!

comment:13 Changed 4 years ago by Saare

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [5935].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy