Opened 6 years ago

Closed 6 years ago

#6027 closed Bug (fixed)

[[FF]] Modifying Table Properties by selecting more than one cell, causing several issues

Reported by: satya Owned by: Saare
Priority: Normal Milestone: CKEditor 3.4.1
Component: General Version: 3.3
Keywords: IBM Cc: damo, joek

Description

To reproduce the defect:

  1. open Ajax sample.
  1. Insert a Table with 5 rows & 6 columns.
  1. Select more than one cell( for ex: Top 2 cells) and click on Table Properties option.
  1. Try to modify any of Table Properties and Click OK button.

Expected Result:

Table properties should be modified successfully.

Actual Result:

we are getting the following error in firebug when we press OK button

k.$ is undefined [Break on this error] h.get=function(i){return i&&(i.$?i:new...turn c?i.replace(/<\?[>]*>/g,):i;

and also when we press cancel and close the dialog, the last Table cell that was selected gets deleted.

And also it is giving the option to edit the No of Rows & Columns for the user which it should not be.

Attachments (2)

6027.patch (665 bytes) - added by Saare 6 years ago.
6027_2.patch (742 bytes) - added by Saare 6 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 6 years ago by Saare

  • Status changed from new to confirmed

comment:2 Changed 6 years ago by fredck

  • Milestone set to CKEditor 3.5

comment:3 Changed 6 years ago by Saare

  • Owner set to Saare
  • Status changed from confirmed to assigned

Changed 6 years ago by Saare

comment:4 Changed 6 years ago by Saare

  • Status changed from assigned to review

comment:5 Changed 6 years ago by fredck

  • Status changed from review to review_failed

The fix is correct, but now that "if" block results redundant, because selectedTable will already be null (or undefined) if getAscendant doesn't find the table. The code should get simplified.

Changed 6 years ago by Saare

comment:6 Changed 6 years ago by Saare

  • Status changed from review_failed to review

comment:7 Changed 6 years ago by fredck

  • Status changed from review to review_passed

comment:8 Changed 6 years ago by Saare

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [5820].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy