BIDI: when we change Table language direction indentation of text in Table cells is not applied correctly.

[Satya Minnekanti]

To reproduce the defect:

1. Open Ajax sample.

2. Insert a Table and enter text in all Table cells, Indent the text in few cells.

3. Activate Context menu and select Table properties option.

4. In the Table Properties dialog on Advanced Tab, change the Language direction of the Table to Right to Left(RTL) and click OK button.

Expected Result:

Table language direction is changed to right,Table cells should be shown as reversed,Table Cells & text in Table cells should appear as a mirror image of Table in previous step and indentation for Paragraphs in Table cells should be changed from left to right.

Actual Result:

Table language direction is changed to right,Table cells are shown as reversed,Table Cells & text in Table cells are appearing as a mirror image of Table in previous step but the indentation for Paragraphs in Table cells still shown as left.

[Frederico Caldeira Knabben]

Screenshot with the current results.

[Frederico Caldeira Knabben]

It WFM here. Maybe I simply didn't understand the issue. So, just to be sure, I've attached screenshots of the editor, before and after changing the table direction.

Should we have anything different here?

[Satya Minnekanti]

Replying to fredck:

It WFM here. Maybe I simply didn't understand the issue. So, just to be sure, I've attached screenshots of the editor, before and after changing the table direction.

Should we have anything different here?

we are talking about indentation of the text in Table cells and it's not changing when you change language direction.you have not applied any indentation to the text in your Table cells.

look at step 2 i have asked to apply some indentation to the text in few cells.

[Frederico Caldeira Knabben]

Ok, my fault. Step 2 has two steps on it, and the second got unobserved.

The problem is that the dialog doesn't perform the same margin switching procedure that is instead executed by the BiDi buttons.

It looks like we'll have to implement a generic solution for it, controlled by the indentation plugin, so we make this feature more generic.

[Tobiasz Cudnik]

I think we just miss lang switch event, to which other plugins could subscribe their content changes.

[Frederico Caldeira Knabben]

Something similar to the event we've introduced for the Remove Format feature would do. So, whenever some code changes the direction of an element, the "dirChanged" event is fired.

[Damian]

Can we assign this to 3.4.2?

[Garry Yao]

Replying to damo:

Can we assign this to 3.4.2?

Ok as it's quite a small change, right now we'll not be adding any more to 3.4.2.

[Tobiasz Cudnik]

Fixed with [5954].

[Garry Yao]

Changeset is broken new table creation, revert with [5959], patch must be revised.

[Tobiasz Cudnik]

The reason was lack of a parent during the table creation. Ive added a dedicated check for this situation.

[Tobiasz Cudnik]

Fixed with [5968].