Opened 6 years ago

Closed 5 years ago

#6109 closed Task (fixed)

use commitContent() and setupContent() methods in pastetext plugin dialog

Reported by: Jangaroo Owned by: Saare
Priority: Normal Milestone: CKEditor 3.5.4
Component: General Version:
Keywords: Cc: frank@…

Description

We are currently integrating CKEditor into ExtJS.

There seems to be a standard pattern for separation of concerns between user interface and data layer.

When a CKEditor shows a dialog data is normally set via the setupContent() method, on okay data is normally stored via the commitContent() method. The pastetext plugin dialog does not follow this pattern. To be reusable in our/ other integrations it should follow this standard pattern.

Find a patch for the ckeditor/_source/plugins/pastetext/dialogs/pastetext.js file attached.

Attachments (3)

patchfile.patch (480 bytes) - added by Jangaroo 6 years ago.
6109.patch (2.8 KB) - added by Saare 5 years ago.
6109_2.patch (8.3 KB) - added by Saare 5 years ago.

Download all attachments as: .zip

Change History (12)

Changed 6 years ago by Jangaroo

comment:1 Changed 6 years ago by Jangaroo

  • Cc frank@… added

Any news on this?

comment:2 Changed 5 years ago by Saare

  • Milestone set to CKEditor 3.5.4
  • Owner set to Saare
  • Status changed from new to assigned
  • Version 3.4 Beta deleted

Changed 5 years ago by Saare

comment:3 Changed 5 years ago by Saare

  • Status changed from assigned to review

comment:4 Changed 5 years ago by garry.yao

  • Status changed from review to review_failed

I don't think the patch achieve the purpose of this ticket, while we expect dialog fields data are populated/collected via setupContent/commitContent, which means, the paste area should have the corresponding setup/commit method to do the job, this make it possible to overwrite the original method for customization, e.g.

Changed 5 years ago by Saare

comment:5 Changed 5 years ago by Saare

  • Status changed from review_failed to review_passed

comment:6 Changed 5 years ago by fredck

:/ aren't we missing the review here?

comment:7 Changed 5 years ago by Saare

  • Status changed from review_passed to review

Sorry, one button too low ;)

comment:8 Changed 5 years ago by garry.yao

  • Status changed from review to review_passed

comment:9 Changed 5 years ago by Saare

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [6799].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy