Opened 6 years ago

Closed 6 years ago

#6129 closed Bug (fixed)

BIDI: Show Blocks should show the HTML Tags on the Right for RTL Languages

Reported by: satya Owned by: Saare
Priority: Normal Milestone: CKEditor 3.4.1
Component: General Version: 3.0
Keywords: IBM Cc: damo, joek

Description

To reproduce the defect:

  1. Open Language sample and change the language to Hebrew or Arabic.
  1. Type some text and click on Show Blocks icon.

Expected Result:

Blocks in the Editor body is shown and HTML Tags for the Paragraphs are displayed on the right hand side since we are using a Right to Left(RTL) Language sample.

Actual Result:

Blocks in the Editor body is shown and HTML Tags for the Paragraphs are displayed on the left hand side.

Attachments (3)

6129.patch (1.1 KB) - added by Saare 6 years ago.
images.zip (3.7 KB) - added by Saare 6 years ago.
images_2.zip (2.6 KB) - added by fredck 6 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 6 years ago by Saare

  • Milestone set to CKEditor 3.4.1
  • Owner set to Saare
  • Status changed from new to assigned
  • Version changed from 3.4 Beta to 3.0

Changed 6 years ago by Saare

comment:2 Changed 6 years ago by Saare

  • Status changed from assigned to review

comment:3 Changed 6 years ago by fredck

  • Status changed from review to review_failed

The patch looks good, but the positioning of the images are still incorrect, because of the extra white-space they have at the right side (some of them even missing it).

So, before proceeding with this patch, please commit new images directly, being sure all of them have 4px padding at right and left.

Changed 6 years ago by Saare

comment:4 Changed 6 years ago by Saare

  • Status changed from review_failed to review

comment:5 Changed 6 years ago by fredck

The new files are still bad. Not the labels are out of alignment.

I'll come with new files to be used on commit.

Changed 6 years ago by fredck

comment:6 Changed 6 years ago by fredck

  • Status changed from review to review_passed

comment:7 Changed 6 years ago by Saare

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [5871].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy