Ticket #6150 (closed Bug: fixed)

Opened 4 years ago

Last modified 3 years ago

Select color dialog is broken in Safari 3

Reported by: wwalc Owned by: Saare
Priority: Normal Milestone: CKEditor 3.4.3
Component: General Version: 3.3
Keywords: Cc:

Description

Since CKEditor 3.3 the "Select color" dialog is broken in Safari 3. To reproduce press "Background color" -> "More colors".

Confirmed on Safari 3.2.3 @ XP, it might be worth to check what caused it because I do not see this error in CKEditor 3.2.2.

Attachments

select_color_safari3.jpg (52.6 KB) - added by wwalc 4 years ago.
6150.patch (1.4 KB) - added by Saare 3 years ago.

Change History

Changed 4 years ago by wwalc

comment:1 Changed 4 years ago by wwalc

  • Status changed from new to confirmed

comment:2 Changed 4 years ago by fredck

Works well with Safari 4.

comment:3 Changed 4 years ago by tobiasz.cudnik

  • Status changed from confirmed to assigned
  • Owner set to tobiasz.cudnik

comment:4 Changed 4 years ago by tobiasz.cudnik

  • Milestone changed from CKEditor 3.4.1 to CKEditor 3.5

This error is due to too much markup inside a color table. It may be partially caused by complicated dialog markup itself.

Removing some parts of all rows (like styles, aria and events) makes color table visible. Reducing number of rows inside of table also results in visible table.

I'm proposing postponing it to 3.5 and rewriting it to styled UL list.

comment:5 Changed 4 years ago by fredck

Based on the screenshot, it looks like a broken innerHTML assignment. Maybe the fix is not so hard, and we may not need such a drastic change.

Let's have some further investigation before proceeding with it.

comment:6 Changed 3 years ago by fredck

  • Milestone changed from CKEditor 3.5 to CKeditor 3.4.3

comment:7 Changed 3 years ago by garry.yao

  • Owner tobiasz.cudnik deleted
  • Status changed from assigned to new

comment:8 Changed 3 years ago by Saare

  • Status changed from new to assigned
  • Owner set to Saare

Changed 3 years ago by Saare

comment:9 Changed 3 years ago by Saare

  • Status changed from assigned to review

The event call breaks the innerHTML assignment.

comment:10 Changed 3 years ago by tobiasz.cudnik

  • Status changed from review to review_passed

Very interesting solution.

comment:11 Changed 3 years ago by Saare

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [6141].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy