Error on maximise command when toolbar button not shown

[William]

Hi,

The maximise plugin has an error, on line 291, when the editor is set to be automaximised on start and the user has opted to not show the maximise button on the toolbar.

_source\plugins\maximize\plugin.js

a possible fix is (adding the lines with +):

+if(button!=null)
  var buttonNode = editor.element.getDocument().getById( button._.id );
  buttonNode.getChild( 1 ).setHtml( label );
  buttonNode.setAttribute( 'title', label );
  buttonNode.setAttribute( 'href', 'javascript:void("' + label + '");' );
+}

I checked nightly build 5826 and problem was evident there.

A thread about the bug. ​http://cksource.com/forums/viewtopic.php?f=11&t=19820

[Charlie]

I changed the title to be a little more descriptive and generic. Hope that's alright! Also, here's his patch in true patch file form.

[William]

Thankyou comp615

[Sa'ar Zac Elias]

Thanks @comp615; Committed as a microchange with [6253].

[Wiktor Walc]

#5329 marked as duplicate