Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#6166 closed Bug (fixed)

Error on maximise command when toolbar button not shown

Reported by: William_ Owned by:
Priority: Normal Milestone: CKEditor 3.5.1
Component: UI : Toolbar Version: 3.3.2
Keywords: HasPatch Cc:

Description

Hi,

The maximise plugin has an error, on line 291, when the editor is set to be automaximised on start and the user has opted to not show the maximise button on the toolbar.

_source\plugins\maximize\plugin.js

a possible fix is (adding the lines with +):

+if(button!=null)
  var buttonNode = editor.element.getDocument().getById( button._.id );
  buttonNode.getChild( 1 ).setHtml( label );
  buttonNode.setAttribute( 'title', label );
  buttonNode.setAttribute( 'href', 'javascript:void("' + label + '");' );
+}

I checked nightly build 5826 and problem was evident there.

A thread about the bug. http://cksource.com/forums/viewtopic.php?f=11&t=19820

Attachments (1)

6166.patch (1.2 KB) - added by comp615 6 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 6 years ago by comp615

  • Keywords HasPatch added; maximise removed
  • Summary changed from maximise of start (no maximise button casuses error) to Error on maximise command when toolbar button not shown
  • Version changed from 3.3.2 to 3.4.1 (SVN - trunk)

I changed the title to be a little more descriptive and generic. Hope that's alright! Also, here's his patch in true patch file form.

Changed 6 years ago by comp615

comment:2 Changed 6 years ago by William_

Thankyou comp615

comment:3 Changed 6 years ago by fredck

  • Status changed from new to confirmed
  • Version changed from 3.4.1 (SVN - trunk) to 3.3.2

comment:4 Changed 5 years ago by fredck

  • Milestone set to CKEditor 3.5.1

comment:5 Changed 5 years ago by Saare

  • Resolution set to fixed
  • Status changed from confirmed to closed

Thanks @comp615; Committed as a microchange with [6253].

comment:6 Changed 5 years ago by wwalc

#5329 marked as duplicate

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy