Multiple styles lost when changing coreStyles_underling to use <span> with inline style

[Steven Wood]

I changed the editor configuration object so that instead of inserting a <u> for underline, it inserts a <span> with an inline style :

coreStyles_underline: {
         element: "span", 
         attributes : {style: "text-decoration: underline"}
}

This works great except that when you apply this to an element that has had e.g. it's font size increased, the "underline" span replaces the font size one, effectively losing that style.

To reproduce - create an editor with the configuration modified as above, enter some text, either change the font family or font size of the text, then underline the text.

[Steven Wood]

Attached modified version of the "autogrow" sample provided with the editor to show the problem.

[Krzysztof Studnik]

I Confirmed this issue. Do You mean that it should work like this:

<span style="font-size: 16px; text-decoration: underline ">

This is some <strong>sample text</strong>. You are using <a href="http://ckeditor.com/">CKEditor</a>.

?

</span>

Instead of:

<span style="font-size: 16px; ">

<span style="text-decoration: underline">

This is some <strong>sample text</strong>. You are using <a href="http://ckeditor.com/">CKEditor</a>.

?

</span>

?

</span>

[Steven Wood]

Hi,

What i see is that when I apply the text size, the DOM contains this :

<span style="font-size: 24px;">

Text <br type="_moz">

</span>

The, when i click the U button to apply underline (where the core style is modified to use a span) the DOM becomes : -

<span style="text-decoration: underline;">

Text <br type="_moz">

</span>

What i would have hoped to see is :

<span style="font-size: 24px;">

<span style="text-decoration: underline;">

Text

</span> <br type="_moz">

</span>

So the spans are nested, whereas at present one seems to replace the other.

thanks, Steve.

[Garry Yao]

The styles specified as inline attribute, should be resolved as the same with definition.styles.

[Frederico Caldeira Knabben]

Please have a test for this when committing.

[Garry Yao]

Fixed with [7599].