Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#6200 closed Bug (fixed)

No Visual Focus when we tab to Check boxes on Find and Replace & Flash Properties dialogs

Reported by: satya Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.6.2
Component: UI : Dialogs Version:
Keywords: IBM Cc: damo, joek

Description

To reproduce the defect:

  1. Open Ajax sample.
  1. Click on Find and Replace Icon & Flash icons in the Tool bar to activate Find and Replace & Flash Properties dialogs.
  1. When dialogs are opened tab through each element to see if the focus is shown properly for all the elements when we are tabbing through them

Focus not shown for Check boxes on both Find and Replace tabs of Find and Replace dialog.

Focus not shown for Check boxes on Properties tabs of Flash Properties dialog.

In IE6 focus is shown around the label for the Check box instead of showing it on the Check box.

Attachments (7)

6200.patch (3.3 KB) - added by Saare 5 years ago.
6200_2.patch (9.0 KB) - added by Saare 5 years ago.
6200_3.patch (2.2 KB) - added by garry.yao 5 years ago.
6200_4.patch (4.8 KB) - added by garry.yao 5 years ago.
6200_5.patch (4.2 KB) - added by garry.yao 5 years ago.
6200_6.patch (4.8 KB) - added by garry.yao 5 years ago.
6200_7.patch (5.8 KB) - added by garry.yao 5 years ago.

Download all attachments as: .zip

Change History (31)

comment:1 Changed 6 years ago by fredck

  • Component changed from General to UI : Dialogs
  • Status changed from new to confirmed

I think it's better us having custom styling for focused checkboxes in the dialogs, instead of relaying on the browser default thing.

comment:2 Changed 6 years ago by garry.yao

  • Milestone set to CKEditor 3.6

comment:3 Changed 5 years ago by tobiasz.cudnik

  • Owner set to tobiasz.cudnik
  • Status changed from confirmed to assigned

comment:4 Changed 5 years ago by fredck

  • Owner tobiasz.cudnik deleted
  • Status changed from assigned to new

comment:5 Changed 5 years ago by fredck

  • Status changed from new to confirmed

comment:6 Changed 5 years ago by fredck

  • Milestone CKEditor 3.6 deleted

Changed 5 years ago by Saare

comment:7 Changed 5 years ago by Saare

  • Cc changed from damo,joek to damo, joek
  • Owner set to Saare
  • Status changed from confirmed to review

comment:8 Changed 5 years ago by garry.yao

  • Status changed from review to review_failed
  • Ratio lock (Image dialog) requires the same fix;
  • Other inputs in Firefox requires also such a fix, including checkbox, ration and select:
    .cke_skin_kama .cke_browser_gecko .cke_dialog_ui_checkbox_input:focus,
    .cke_skin_kama .cke_browser_gecko .cke_dialog_ui_input_select:focus
    {
    	outline:#696969 dotted 1px;
    }
    

comment:9 Changed 5 years ago by garry.yao

  • Summary changed from IE 7 - No Visual Focus when we tab to Check boxes on Find and Replace & Flash Properties dialogs to No Visual Focus when we tab to Check boxes on Find and Replace & Flash Properties dialogs

Update ticket as it's not an IE specific issue.

Changed 5 years ago by Saare

comment:10 Changed 5 years ago by Saare

  • Status changed from review_failed to review

Changed 5 years ago by garry.yao

comment:11 Changed 5 years ago by garry.yao

  • Owner changed from Saare to garry.yao

Previous patch contains some unnecessary changes, besides, ratio is subjected to the fix also.

comment:12 Changed 5 years ago by Saare

  • Status changed from review to review_failed

The patch doesn't bring any change at all.

Changed 5 years ago by garry.yao

comment:13 Changed 5 years ago by garry.yao

  • Status changed from review_failed to review

comment:14 Changed 5 years ago by Saare

  • Status changed from review to review_failed

In NATIVE IE6, there are now borders around checkboxes and the ratio images.

comment:15 Changed 5 years ago by Saare

#8013 is a dup.
Note: Select boxes are also to be considered in FF.

Last edited 5 years ago by Saare (previous) (diff)

Changed 5 years ago by garry.yao

comment:16 Changed 5 years ago by garry.yao

  • Status changed from review_failed to review

The patch takes care of the IE6 fake border issue.

comment:17 Changed 5 years ago by Saare

  • Status changed from review to review_failed

Problem's still not solved in Opera.

Changed 5 years ago by garry.yao

comment:18 Changed 5 years ago by garry.yao

  • Status changed from review_failed to review

Ok...now have Opera included into the fixes.

comment:19 Changed 5 years ago by Saare

  • Status changed from review to review_failed

Seems like the patch has no effect at all in IE6-7 now.

Changed 5 years ago by garry.yao

comment:20 Changed 5 years ago by garry.yao

  • Status changed from review_failed to review

comment:21 Changed 5 years ago by Saare

  • Status changed from review to review_passed

comment:22 Changed 5 years ago by fredck

  • Milestone set to CKEditor 3.6.2

comment:23 Changed 5 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [7222].

comment:24 Changed 5 years ago by satya

The patch did not fixed the Visual Focus issue in High contrast mode. In High Contrast mode, we are not seeing Visual Focus when we tab to Check boxes & list boxes on all dialogs.

Please re open this ticket

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy