Ticket #6215 (closed Bug: fixed)

Opened 4 years ago

Last modified 3 years ago

copied bold content not editable

Reported by: yiminghe Owned by: Saare
Priority: Normal Milestone: CKEditor 3.5.3
Component: Core : Styles Version: 3.4
Keywords: Cc:

Description (last modified by krst) (diff)

if user copy content from web somewhere to ckeditor ,the html code is

<span style="font-weight: bold;">bold</span>

the editor's bold button (alway off state) is unusable for copied content.

and if i change coreStyles_bold in _source\plugins\basicstyles\plugin.js line 54 to

{ element        : 'span',
                styles        : { 'font-weight' : 'bold' },
                overrides    : [
                    { element : 'b' },
                    { strong : 'strong' },
                ] };

when user copy

<b>bold</b>

to sourcearea ,and place cursor in the middle of bold (do not select a character) at wysiwyg mode ,the bold button's state is on,but if clicked ,nothing happened

i modified code file (ckeditor 3.4) : _source/plugins/styles/plugin.js line 603

from

removeFromElement( this, element );

to

if ( element.getName() == this.element )
						removeFromElement( this, element );
					else
						removeOverrides( element, getOverrides( this )[ element.getName() ] );

problem solved ,hope helpful

Attachments

6215.patch (574 bytes) - added by Saare 4 years ago.

Change History

comment:1 Changed 4 years ago by krst

  • Status changed from new to review
  • Owner set to krst
  • Description modified (diff)
  • Keywords HasPatch added

After both changes has been made,

<span style="font-weight: bold;">bold</span>
<b>bold</b>

It is possible to switch style between bold and normal.

Checked on 3.4.1 SVN

comment:2 Changed 4 years ago by krst

  • Status changed from review to review_passed

comment:3 Changed 4 years ago by wwalc

  • Status changed from review_passed to new
  • Owner krst deleted
  • Milestone set to CKEditor 3.5.2

@krst - please attach a correct patch and change the status to review if you'd like to take the ownership of this ticket (the same developer cannot change the status to review and review_passed)

Changed 4 years ago by Saare

comment:4 Changed 4 years ago by Saare

  • Owner set to Saare
  • Status changed from new to review

comment:5 Changed 4 years ago by garry.yao

  • Status changed from review to review_passed
  • Keywords HasPatch removed

comment:6 Changed 4 years ago by Saare

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [6415].

comment:7 Changed 3 years ago by krst

#705 is a DUP

Last edited 3 years ago by krst (previous) (diff)
Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy