Opened 6 years ago

Closed 6 years ago

#6278 closed Bug (fixed)

comment tags get moved to top

Reported by: MBcode Owned by: paho
Priority: Normal Milestone: CKEditor 3.5.1
Component: Core : Output Data Version: 3.4
Keywords: Cc:

Description (last modified by krst)

Hey there, In Source editing mode paste original default Text:

%header%<br />
<br />
<!--start:problem[0]--><br />
<!--stop:problem[0]--><br />
<!--start:result[0]--><br />
<!--stop:result[0]--><br />

<!--start:info[0]--><br />
<!--stop:info[0]--><br />
<!--start:end[0]--><br />
<!--stop:end[0]--><br />
<br />
<!--start:sorry[0]--><br />
<!--stop:sorry[0]--><br />
<br />

Switch to WYSIWYG and back to source editing. it gets formatted to:

%header%<br />
<br />
<!--start:problem[0]--><!--stop:problem[0]--><!--start:result[0]--><!--stop:result[0]--><!--start:info[0]--><!--stop:info[0]--><!--start:end[0]--><!--stop:end[0]--><!--start:sorry[0]--><!--stop:sorry[0]--><br />
<br />
<br />
<br />
<br />
<br />
<br />
<br />
<br />
<br />
<br />
<br />
<br />

This isnt rly usefull because I like to use Comments to Insert with Javascript at the given position.

Please fix that! Would be really great.

Attachments (1)

6278.patch (427 bytes) - added by paho 6 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 6 years ago by krst

  • Component changed from General to UI : Source View
  • Description modified (diff)
  • Keywords comment tags removed
  • Status changed from new to confirmed

Confirmed on 3.4.1 Nightly & Demo. Source formating is lost in above case. I changed formating of issue.

comment:2 Changed 6 years ago by paho

  • Owner set to paho
  • Status changed from confirmed to assigned

Changed 6 years ago by paho


comment:3 Changed 6 years ago by paho

  • Status changed from assigned to review

comment:4 Changed 6 years ago by paho

It looks like regression, introduced in 3.1 (revision 5103):

by fixing the ticket #4886:

comment:5 Changed 6 years ago by MBcode

Is there any ETA for the fix? Seems that the patch not work. I also noticed latest comment, so there wont be a fix? :(

patch -p0 < 6278.patch 
(Stripping trailing CRs from patch.)
patching file _source/core/htmlparser/fragment.js
Hunk #1 FAILED at 386.
1 out of 1 hunk FAILED -- saving rejects to file _source/core/htmlparser/fragment.js.rej

comment:6 Changed 6 years ago by wwalc

  • Milestone set to CKEditor 3.5.1

comment:7 Changed 6 years ago by Saare

  • Status changed from review to review_passed

comment:8 Changed 6 years ago by Saare

  • Component changed from UI : Source View to Core : Output Data
  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [6284].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy