Ticket #6308 (closed Bug: fixed)

Opened 4 years ago

Last modified 2 years ago

"vertical" resize_dir still sets width CSS

Reported by: LloydSkoyd Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.6.3
Component: UI : Toolbar Version: 3.4
Keywords: Cc: mcianc@…

Description (last modified by krst) (diff)

When resize_dir is configured to be "vertical", only vertical size changes should be allowed. However, after some vertical resizing, a width CSS style (in px) is set on the editor span. For example:

style="width:1019px"

This is a problem if the editor is supposed to be 100% wide. The editor is now stuck at being the same width, even when the window/container resizes.

The same issue probably applies to "horizontal" resize_dir, but with a height CSS style.

Both issues can be fixed by changing the editor resize function call in resize/plugin.js line43 to:

  editor.resize( resizeHorizontal ? width : null, resizeVertical ? height : null );

This will cause the width/height to only be changed when necessary.

Attachments

6308.patch (589 bytes) - added by garry.yao 2 years ago.

Change History

comment:1 Changed 4 years ago by krst

  • Status changed from new to confirmed
  • Keywords HasPatch added; resize removed
  • Description modified (diff)

Confirmed. After applying provided change, editor resizes itself depending on window size

comment:2 Changed 4 years ago by mcianc

  • Cc mcianc@… added

comment:3 follow-up: ↓ 4 Changed 4 years ago by krst

linked with #6565

comment:4 in reply to: ↑ 3 Changed 4 years ago by krst

Replying to krst:

linked with #6565

I linked this with wrong issue, it should be #6365

comment:5 Changed 3 years ago by fbingha

The suggested fix works, let's get this in.

Changed 2 years ago by garry.yao

comment:7 Changed 2 years ago by garry.yao

  • Status changed from confirmed to review
  • Keywords HasPatch removed
  • Component changed from General to UI : Toolbar
  • Owner set to garry.yao

We dont need to fix the horizontal-only resize since percentage val is not supported for editor height.

comment:8 Changed 2 years ago by fredck

  • Status changed from review to review_passed
  • Milestone set to CKEditor 3.6.3

Please fix the coding style when committing.

comment:9 Changed 2 years ago by garry.yao

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [7386].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy