Opened 6 years ago

Closed 6 years ago

#6332 closed Bug (fixed)

IE: V2 skin bottom dialog's border broken

Reported by: tobiasz.cudnik Owned by: paho
Priority: Normal Milestone: CKEditor 3.4.2
Component: UI : Dialogs Version: 3.4
Keywords: IE Cc:

Description

V2 skin bottom dialog's border is broken in IE since version 3.4. It was fine in 3.4 Beta and 3.3.2.

Refer to attached screenshot. Reproduced on IE8 standards mode.

Attachments (4)

2010-09-21-123724_490x499_scrot.png (17.5 KB) - added by tobiasz.cudnik 6 years ago.
6332.patch (427 bytes) - added by paho 6 years ago.
Patch
6332_2.patch (5.8 KB) - added by paho 6 years ago.
Patch
6332_3.patch (2.0 KB) - added by paho 6 years ago.
Patch

Download all attachments as: .zip

Change History (18)

Changed 6 years ago by tobiasz.cudnik

comment:1 Changed 6 years ago by Saare

  • Milestone set to CKEditor 3.4.2
  • Status changed from new to confirmed

comment:2 Changed 6 years ago by paho

  • Owner set to paho
  • Status changed from confirmed to assigned

comment:3 Changed 6 years ago by paho

Regresion introduced in revision 5840: http://dev.ckeditor.com/changeset/5840

comment:4 Changed 6 years ago by paho

'change' event is not fired because of 'noChangeEvent' flag that is always set to 'true'.

comment:5 Changed 6 years ago by paho

Regression connected with ticket #6137: http://dev.ckeditor.com/ticket/6137

comment:6 Changed 6 years ago by paho

Because 'change' event is not fired, body.$.offsetHeight of dialog window is not recalculated and the vertical borders are too long. We must expand the content of the dialog window to be as long as borders.

Changed 6 years ago by paho

Patch

comment:7 Changed 6 years ago by paho

  • Status changed from assigned to review

comment:8 Changed 6 years ago by Saare

  • Status changed from review to review_failed

I've seen similar things happen randomly also in office2003. A more generic solution could be found.

comment:9 Changed 6 years ago by paho

I reverted changes from revision [5840] and added new patch resolving ticket #6137 without dialog window css problem.

Changed 6 years ago by paho

Patch

comment:10 Changed 6 years ago by paho

  • Status changed from review_failed to review

comment:11 Changed 6 years ago by Saare

  • Status changed from review to review_failed

We didn't take your proposed approach earlier because we concluded that it's more than just this specific field. We'll face the same problem everytime we use this event, i.e. when there is a default height set in this dialog.

Changed 6 years ago by paho

Patch

comment:12 Changed 6 years ago by paho

  • Status changed from review_failed to review

comment:13 Changed 6 years ago by garry.yao

  • Status changed from review to review_passed

comment:14 Changed 6 years ago by paho

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [5945]

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy