Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#6408 closed Bug (fixed)

AutoGrow 24px too high on IE

Reported by: dinu Owned by: Saare
Priority: Normal Milestone: CKEditor 3.4.2
Component: General Version: 3.4.2
Keywords: IE Cc:

Description

On IE 7,8 the autogrow computed size is 24px too high; I've tracked it down to
newHeight = doc.getBody().$.scrollHeight + 24;
I don't know what that adjustment is for; I'm assuming it's to compensate for an eventual horizontal scrollbar, in which case:

  • 24 is tentative, the scrollbars are not expected to have a certain size, so scrollbar height should be computed by other means
  • only add height if a hrz scrollbar is actually present
  • if additional height is added, schedule another resize to shrink editor back if scrollbars go away as result of the first resize; although it's counterintuitive (the horizontal scrollbar going away on a vertical resize, it's been known to happen)

I'll try to look some more at this and figure a way for myself

Attachments (3)

6408.patch (668 bytes) - added by Saare 6 years ago.
24px.jpg (189.6 KB) - added by dinu 6 years ago.
6408_2.patch (665 bytes) - added by dinu 6 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 6 years ago by Saare

  • Keywords IE added
  • Milestone set to CKEditor 3.4.2
  • Status changed from new to confirmed
  • Version set to 3.4

Confirmed on Quirks mode.

Changed 6 years ago by Saare

comment:2 Changed 6 years ago by Saare

  • Owner set to Saare
  • Status changed from confirmed to review

comment:3 Changed 6 years ago by garry.yao

  • Status changed from review to review_passed

comment:4 Changed 6 years ago by Saare

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [5924].

comment:5 Changed 6 years ago by dinu

  • Version changed from 3.4 to 3.4.2

Reopen: not fixed
Test: IE8/IE8 Standards, IE8 Compat/IE7 Standards

Problem:
CKEDITOR.env.ie&&CKEDITOR.env.quirks?0:24
Should (probably?) be the other way around:
CKEDITOR.env.ie&&CKEDITOR.env.quirks?24:0

Side comment:
According to http://msdn.microsoft.com/en-us/library/ms533687(VS.85).aspx compatMode is deprecated, use documentMode if available for quirks mode detection. Haven't tested, just a thought.

comment:6 Changed 6 years ago by dinu

Side note 2: CKEDITOR.env.ie&& is redundant

comment:7 Changed 6 years ago by garry.yao

Test: IE8/IE8 Standards, IE8 Compat/IE7 Standards

It works for me for those modes, could you attach a screenshot/screencast?

Changed 6 years ago by dinu

comment:8 Changed 6 years ago by dinu

Done. Your written code does this: adds 0px if the browser IS in quirks mode and 24px if it's in standards mode. Shouldn't it be the other way around?

Changed 6 years ago by dinu

comment:9 Changed 6 years ago by dinu

Please review... one simple thing less to maintain.

comment:10 Changed 6 years ago by dinu

Bump. Again need to repatch release.

comment:11 Changed 6 years ago by garry.yao

Please avoid adding comments to fixed ticket, #7173 has been opened for all issues mentioned.

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy