Error occurring when trying to insert a table over a highlighted list

[James]

Steps to reproduce the defect:

1. Open the Ajax sample.
2. Create a numbered/bulleted list containing 5 items.
3. Press CTRL + A to highlight all of the text. (note: if using FF highlight the text using the mouse)
4. Click on the Insert Table icon in the toolbar.
5. Press OK in the Table Properties dialog.

Expected: The table dialog should close and a table should appear in the editor.

Actual: The table dialog does not close and the text in the list disappears leaving 2 empty bullets/numbers. Also, an error occurs. (details of the error are in the screenshot)

[James]

Error related to the defect

[Martin]

How is Your expectation about this case ? Similar situation with paragraph works that inserting table remove selected items.

[James]

I would expect the following to occur:

1. The table dialog would close.
2. The list will be completely removed.
3. The table will be displayed in the editor overriding the list.

[Martin]

What if we select for example 2 items of 5 items length list, we should completly remove list or only slected items to replace them by table ?

[Tobiasz Cudnik]

Let's not complicate the case, the new table should remove the list like every other selected element, even if it's partially selected. Although for nested lists, it should remove only a deeper one.

[Garry Yao]

Replying to tobiasz.cudnik:

Let's not complicate the case, the new table should remove the list like every other selected element...

For me it should break the list into two instead.

[Garry Yao]

When only get partially selected, extract content should not delete the entire list but break it into two parts. Replying to garry.yao:

Replying to tobiasz.cudnik:

Let's not complicate the case, the new table should remove the list like every other selected element...

For me it should break the list into two instead.

[Martin]

I think we should sum up how this functionality should work:

Let`s assume we have such a situations:

I situation

<ul>
 <li>A</li>
 <li>[B]</li> 
 <li>C</li>
<ul>

so after insert table I expect:

<ul>
 <li>A</li>
 <li> <table></table> </li> 
 <li>C</li>
<ul>

II situation:

<ul>
 <li>A</li>
 <li>B^</li> 
 <li>C</li>
<ul>

After insert table I expect

<ul>
 <li>A</li>
 <li>B<table></table></li> 
 <li>C</li>
<ul>

III situation

<ul>
 <li>[A</li>
 <li>B</li> 
 <li>C]</li>
<ul>

After insert table I expect

<table></table>

IV situation

<ul>
 <li>A</li>
 <li>
  <ul>
   <li>B</li> 
   <li>[C</li> 
  </ul>
 </li>
 <li>D]</li>
<ul>

You think we should replace all list or create one of list as under:

<ul>
 <li>A</li>
 <li>
   <ul>
     <li>B</li>
   </ul>
 </li>
 <li><table></table></li>
<ul>

OR

<ul>
 <li>A</li>
 <li>
   <ul>
     <li>B</li>
     <li><table></table></li>
   </ul>
 </li>
<ul>

[Garry Yao]

Nice to see those cases are clear listed here, I don't know too, it maybe browser dependent? But the best way to check the expected results is to have the table insertion work just like pasting a table with the same selection.

[Tobiasz Cudnik]

I'm taking over this ticket over Mani.

[Tobiasz Cudnik]

This is yet another approach, which does simple unification on the selection across a list elements. It has more similar results in various browsers than usage of insertHtml function from the second patch.

[Sa'ar Zac Elias]

Please update the patch.

[Garry Yao]

6432_3.patch doesn't achieve the result requested by comment:6.

[Garry Yao]

Note that the list selection in IE has a bug that it's always impossible to select a full list (proved by clicking on path bar), propose a simple fix to range::deleteContents that handles this situation in a better way, as there's no fix could be delivered on the browser side.

[Sa'ar Zac Elias]

I didn't test the patch yet, but the patch targets IE only, what about other browsers?

[Sa'ar Zac Elias]

The patch fixes the initial TC, please open another ticket for the rest of the TCs.

[Garry Yao]

Fixed with [6334].

#6986 is created for selection with partial list.