Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#6479 closed Bug (fixed)

BIDI: Language direction is not being preserved when pressing Enter after a paragraph format has been applied.

Reported by: james c Owned by: paho
Priority: Normal Milestone: CKEditor 3.4.3
Component: UI : Enter Key Version: 3.4
Keywords: IBM Cc: damo, joek, satya

Description

Steps to reproduce the defect:

  1. Open the Ajax sample.
  2. Type a line of text in the editor.
  3. Apply Heading 1 paragraph format to the text.
  4. Click the RTL icon.
  5. Position the cursor at the end of the text & press Enter.

Expected: The cursor preserves the RTL language direction and appears on the right side of the editor.

Actual: The cursor now has LTR language direction and appears on the left side of the editor.

Attachments (3)

6479.patch (1.9 KB) - added by paho 6 years ago.
Patch
6479_2.patch (2.0 KB) - added by paho 6 years ago.
Patch
6479_3.patch (2.2 KB) - added by paho 6 years ago.
Patch

Download all attachments as: .zip

Change History (15)

comment:1 Changed 6 years ago by garry.yao

  • Component changed from General to UI : Enter Key
  • Status changed from new to confirmed
  • Version changed from 3.4.1 to 3.4

comment:2 Changed 6 years ago by fredck

  • Milestone set to CKeditor 3.4.3

comment:3 Changed 6 years ago by paho

  • Owner set to paho
  • Status changed from confirmed to assigned

Changed 6 years ago by paho

Patch

comment:4 Changed 6 years ago by paho

  • Status changed from assigned to review

comment:5 Changed 6 years ago by garry.yao

  • Status changed from review to review_failed

Note that styles other than the direction will not move as we're talking about existing from the headers in this case.

Changed 6 years ago by paho

Patch

comment:6 Changed 6 years ago by paho

  • Status changed from review_failed to review

comment:7 Changed 6 years ago by garry.yao

  • Status changed from review to review_failed

How about element::getDirection instead of hasAttribute( 'dir' ) ?

Changed 6 years ago by paho

Patch

comment:8 Changed 6 years ago by paho

  • Status changed from review_failed to review

comment:9 Changed 6 years ago by garry.yao

  • Status changed from review to review_passed

comment:10 Changed 6 years ago by paho

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [6078].

comment:11 Changed 6 years ago by paho

Reverted [6078]. Fixed with [6080].

comment:12 Changed 6 years ago by paho

Fixed with [6091].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy