Ticket #6488 (closed Bug: invalid)

Opened 4 years ago

Last modified 3 years ago

Image dialog validation should not allow a value of zero be entered numeric fields

Reported by: JoeK Owned by:
Priority: Normal Milestone:
Component: General Version: 3.5
Keywords: IBM Cc: damo, jamcunni@…

Description

The Image dialog allows zero to be entered for image width and height. When zero is entered the image is not visible and it is difficult to select to edit the image's properties.

The Image dialog also allows zero to be entered for Horizontal Space, Vertical Space and Border. A value of zero does not cause a visual effect, but an inline style is applied. The inline style should not be applied if it has no effect. Either validation should not allow a value of zero, or zero can be allowed but it results in no inline style being applied.

Change History

comment:1 Changed 4 years ago by james c

  • Cc jamcunni@… added

comment:2 Changed 4 years ago by alfonsoml

It can be argued if zero width and height are correct or not, but for sure they are valid values for any other field and should set the inline style or attribute.

The site's css might specify a default value for those attributes, and as long as those fields are available in the dialog the user should be able to use them to override the defaults (for me it's much better to remove all those fields and put only a class selector)

comment:3 Changed 3 years ago by garry.yao

  • Status changed from new to closed
  • Resolution set to invalid

Please use our dialog customization system for changing dialog validation rule.

comment:4 Changed 3 years ago by JoeK

I agree with alfonsoml regarding being able to override default styles.

Interesting to note that Microsoft Word does not allow a value of zero for image width and height, which makes sense to me.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy