Opened 6 years ago

Closed 6 years ago

#6508 closed Bug (fixed)

BiDi: Margin mirroring logic doesn't honor CSS direction

Reported by: tobiasz.cudnik Owned by: tobiasz.cudnik
Priority: Normal Milestone: CKEditor 3.4.2
Component: General Version:
Keywords: Cc:

Description

This is a small fix.

Margin mirroring logic doesn't honor CSS direction set for an element, dom.element#getDirection method should be used by it instead.

Attachments (1)

6508.patch (627 bytes) - added by tobiasz.cudnik 6 years ago.

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by tobiasz.cudnik

comment:1 Changed 6 years ago by tobiasz.cudnik

  • Owner set to tobiasz.cudnik
  • Status changed from new to review

comment:2 follow-up: Changed 6 years ago by Saare

  • Status changed from review to review_passed

That could be a micro-change though.

comment:3 in reply to: ↑ 2 Changed 6 years ago by fredck

Replying to Saare:

That could be a micro-change though.

I don't think so... even if small, it's a logic change, so it needs review.

comment:4 Changed 6 years ago by tobiasz.cudnik

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [5996].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy