Ticket #6566 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

Impossible to get out of blockquote on enterMode = BR

Reported by: Saare Owned by: Saare
Priority: Normal Milestone: CKEditor 3.5.1
Component: Core : Styles Version:
Keywords: Cc: pomu@…

Description (last modified by Saare) (diff)

  • Set enterMode = BR and open a sample.
  • Type 3 rows.
  • Apply blockquote.

Note that *everything* is inside the blockquote. You can not get out of it.
IMHO, it should act like that:

  • If the selection is not collapsed, only transform the selected rows into blockquote.
  • If the selection is collapsed, the row in which the caret is placed should be the blockquote.
  • Exiting the blockquote could be done when clicking the blockquote button again.

Also, what do you think of having a possibility to exit a blockquote with double-Enter, just like exiting a list item?

Attachments

6566.patch (433 bytes) - added by Saare 4 years ago.

Change History

comment:1 Changed 4 years ago by Saare

  • Description modified (diff)

comment:2 Changed 4 years ago by garry.yao

  • Keywords Discussion added
  • Type changed from Bug to New Feature

comment:3 Changed 4 years ago by gav

I know this is marked as "New Feature", but I think it should be marked as a bug. FCK did not work like this, if you had content that only had BRs in it, it would still only indent one "paragraph", not the whole document. This is definitely a regression from the FCK version of the plugin. If needed, I can stand up a test environment to demonstrate the regression.

comment:4 Changed 4 years ago by gav

(For clarity's sake, my comment above applies to FF 3.6 on OSX).

comment:5 Changed 4 years ago by garry.yao

  • Status changed from new to confirmed
  • Keywords Discussion removed
  • Type changed from New Feature to Bug
  • Component changed from General to Core : Styles
  • Milestone set to CKEditor 3.5.1

@gav Thanks for the remind, it's indeed a bug, "div" plugin is also affected AFAIK, the "new feature" I'm seeing in the ticket is actually the proposal of "having a possibility to exit a blockquote with double-Enter, just like exiting a list item".

comment:6 Changed 4 years ago by fredck

I would be cautious regarding the double ENTER thing. Especially when enterMode=BR, the user may want to stay into the blockquote to separate blocks of texts on it.

As it's possible to leave the blockquote by clicking its relative button, let's fix the bug first, leaving this new feature for future discussions.

comment:7 Changed 4 years ago by pomu0325

  • Cc pomu@… added

Changed 4 years ago by Saare

comment:8 Changed 4 years ago by Saare

  • Status changed from confirmed to review
  • Owner set to Saare

comment:9 Changed 4 years ago by tobiasz.cudnik

  • Status changed from review to review_passed

The patch fixes exiting from a blockquote in entermode BR by using a toolbar button.

comment:10 follow-up: ↓ 11 Changed 4 years ago by garry.yao

  • Status changed from review_passed to review_failed

But why there's an extra paragraph created automatically there in blockquote?

comment:11 in reply to: ↑ 10 Changed 4 years ago by garry.yao

Replying to garry.yao:

But why there's an extra paragraph created automatically there in blockquote?

An existing problem, tracked at #6910.

comment:12 Changed 4 years ago by Saare

  • Status changed from review_failed to closed
  • Resolution set to fixed

Fixed with [6264].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy