Opened 14 years ago
Closed 14 years ago
#6629 closed Bug (fixed)
Inconsistent behavior when applying paragraph format
Reported by: | Wiktor Walc | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.6 |
Component: | General | Version: | 3.1 |
Keywords: | Cc: |
Description
When "Formatted" paragraph format is used, the behavior of the editor is different that ussual.
Steps to reproduce
Scenario 1
- starting with a new blank page
- select "Heading 2" format
- switch to source mode
- result: no HTML code, source is empty
- switch to wysiwyg mode
- result: "Heading 2" is still selected
Scenario 2
- starting with a new blank page
- select "Formatted" fomat
- switch to source mode
- result: HTML source
<pre> </pre> <p> </p>
Problems:
- HTML source is not empty
- There is an empty paragraph at the bottom
Attachments (3)
Change History (14)
comment:1 Changed 14 years ago by
Milestone: | → CKEditor 3.4.3 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
comment:3 Changed 14 years ago by
Milestone: | CKEditor 3.4.3 → CKEditor 3.5.1 |
---|---|
Resolution: | fixed |
Status: | closed → reopened |
I've reverted [6142] with [6181] because the SHIFT+ENTER strategy to move out our <pre> is counter-intuitive.
A better solution need to be found. Probably aligning the <pre> behavior to <p> is the best we should do, just like proposed at ticket:5402#comment:11.
comment:5 Changed 14 years ago by
Milestone: | CKEditor 3.5.1 → CKEditor 3.6 |
---|
Considering that #6841 is targeted to 3.6, moving this one there.
Changed 14 years ago by
Attachment: | 6629.patch added |
---|
comment:6 Changed 14 years ago by
Owner: | set to Garry Yao |
---|---|
Status: | confirmed → review |
Besides the keystroke change, the patch propose of using <br> consistently in all browsers inside pre-formatted block which leads to following benefits:
- Reduce selection bug introduced by using text-only breaks;
- Easier range position management after line break insertion.
Changed 14 years ago by
Attachment: | 6629_2.patch added |
---|
comment:7 Changed 14 years ago by
comment:8 Changed 14 years ago by
Status: | review → review_failed |
---|
I'm still having an empty <pre> in the source view (reported problem "1").
Changed 14 years ago by
Attachment: | 6629_3.patch added |
---|
comment:9 Changed 14 years ago by
Status: | review_failed → review |
---|
comment:10 Changed 14 years ago by
Status: | review → review_passed |
---|
comment:11 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [6698] on trunk.
Fixed with [6142].