Ticket #6664 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

Extra Space between Page Breaks after moving from Source to Wysiwyg mode.

Reported by: naresh.sivaraman Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.6
Component: General Version: 3.4.2
Keywords: Oracle Cc:

Description

Tested in IE8.

To reproduce: (1)Add two page breaks on the editor. (2)Remove the line(gap) between them. (3)Go to source and come back to wysiwyg. (4)The line and the gap is back.

Issue is happening because on doing step 2, the div of the second page break falls inside the <p>. This can be seen when we move to source. So, when we come back to wysiwyg, the <p> is closed with a &nbsp;</p> and the div is seperate.

Attachments

ckeditor_bug_pb.txt (556 bytes) - added by naresh.sivaraman 4 years ago.
6664.patch (5.7 KB) - added by garry.yao 4 years ago.
6664_2.patch (7.0 KB) - added by garry.yao 4 years ago.
6664_3.patch (7.1 KB) - added by garry.yao 4 years ago.
6664_4.patch (7.0 KB) - added by garry.yao 4 years ago.
6664_5.patch (7.1 KB) - added by garry.yao 4 years ago.

Change History

Changed 4 years ago by naresh.sivaraman

Changed 4 years ago by garry.yao

comment:1 Changed 4 years ago by garry.yao

  • Status changed from new to confirmed
  • Milestone set to CKEditor 3.5.1

We've been suffering from the problem that the fake elements (image) that we use were treated by the browser as they were, even it's been displayed as block.

After 3.4, we introduced the contenteditable support, a nice substitution of fake elements in certain cases, the advantages include:

  1. True semantic (no more '_cke_real_element_type' );
  2. Better performance on output(no fake element transformation);

The patch propose an attempt in this approach.

comment:2 Changed 4 years ago by fredck

  • Milestone changed from CKEditor 3.5.1 to CKEditor 3.6

comment:3 Changed 4 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from confirmed to review

The bug affects also FF.

comment:4 Changed 4 years ago by wwalc

  • Keywords Oracle added

comment:5 Changed 4 years ago by Saare

  • Status changed from review to review_failed

Patch should be updated.

Changed 4 years ago by garry.yao

comment:6 Changed 4 years ago by garry.yao

  • Status changed from review_failed to review

comment:7 Changed 4 years ago by Saare

  • Status changed from review to review_failed
  • Add a page break. Click it.
  • See that the format combo displays div. Open the combo and click on div.

Note that a bookmark is being added above.

comment:8 Changed 4 years ago by garry.yao

  • Status changed from review_failed to review

Ok, I've made a change to styles plugin which disallows style change on read-only blocks.

Changed 4 years ago by garry.yao

comment:9 Changed 4 years ago by Saare

  • Status changed from review to review_failed

The object now becomes unselectable thus it cannot be dragged (IE at least). This is counterintuitive. Note that this attribute should not be outputed, in any case.

Changed 4 years ago by garry.yao

comment:10 Changed 4 years ago by garry.yao

  • Status changed from review_failed to review

comment:11 Changed 4 years ago by Saare

  • Status changed from review to review_failed
  • Create the following selection:
    <p>
    	text [text text</p>
    <div style="page-break-after: always;" title="Page Break">
    	<span style="display: none;">&nbsp;</span></div>
    <p>
    	text text] text</p>
    
  • In the format combo, choose "heading 2".

Result: div is transformed into h2.
Also, on output, the page break should not have the title attribute.

Changed 4 years ago by garry.yao

comment:12 Changed 4 years ago by garry.yao

  • Status changed from review_failed to review

The style application issue is a current editor limitation, filed #7694.

comment:13 Changed 4 years ago by Saare

  • Status changed from review to review_passed

comment:14 Changed 4 years ago by garry.yao

Fixed with [6764], thanks Saar for the high quality review.

comment:15 Changed 4 years ago by garry.yao

  • Status changed from review_passed to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy