Opened 14 years ago
Closed 14 years ago
#6664 closed Bug (fixed)
Extra Space between Page Breaks after moving from Source to Wysiwyg mode.
| Reported by: | naresh.sivaraman | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.6 |
| Component: | General | Version: | 3.4.2 |
| Keywords: | Oracle | Cc: |
Description
Tested in IE8.
To reproduce: (1)Add two page breaks on the editor. (2)Remove the line(gap) between them. (3)Go to source and come back to wysiwyg. (4)The line and the gap is back.
Issue is happening because on doing step 2, the div of the second page break falls inside the <p>. This can be seen when we move to source. So, when we come back to wysiwyg, the <p> is closed with a </p> and the div is seperate.
Attachments (6)
Change History (21)
Changed 14 years ago by
| Attachment: | ckeditor_bug_pb.txt added |
|---|
Changed 14 years ago by
| Attachment: | 6664.patch added |
|---|
comment:1 Changed 14 years ago by
| Milestone: | → CKEditor 3.5.1 |
|---|---|
| Status: | new → confirmed |
comment:2 Changed 14 years ago by
| Milestone: | CKEditor 3.5.1 → CKEditor 3.6 |
|---|
comment:3 Changed 14 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | confirmed → review |
The bug affects also FF.
comment:4 Changed 14 years ago by
| Keywords: | Oracle added |
|---|
Changed 14 years ago by
| Attachment: | 6664_2.patch added |
|---|
comment:6 Changed 14 years ago by
| Status: | review_failed → review |
|---|
comment:7 Changed 14 years ago by
| Status: | review → review_failed |
|---|
- Add a page break. Click it.
- See that the format combo displays div. Open the combo and click on div.
Note that a bookmark is being added above.
comment:8 Changed 14 years ago by
| Status: | review_failed → review |
|---|
Ok, I've made a change to styles plugin which disallows style change on read-only blocks.
Changed 14 years ago by
| Attachment: | 6664_3.patch added |
|---|
comment:9 Changed 14 years ago by
| Status: | review → review_failed |
|---|
The object now becomes unselectable thus it cannot be dragged (IE at least). This is counterintuitive. Note that this attribute should not be outputed, in any case.
Changed 14 years ago by
| Attachment: | 6664_4.patch added |
|---|
comment:10 Changed 14 years ago by
| Status: | review_failed → review |
|---|
comment:11 Changed 14 years ago by
| Status: | review → review_failed |
|---|
- Create the following selection:
<p> text [text text</p> <div style="page-break-after: always;" title="Page Break"> <span style="display: none;"> </span></div> <p> text text] text</p>
- In the format combo, choose "heading 2".
Result: div is transformed into h2.
Also, on output, the page break should not have the title attribute.
Changed 14 years ago by
| Attachment: | 6664_5.patch added |
|---|
comment:12 Changed 14 years ago by
| Status: | review_failed → review |
|---|
The style application issue is a current editor limitation, filed #7694.
comment:13 Changed 14 years ago by
| Status: | review → review_passed |
|---|
comment:15 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
We've been suffering from the problem that the fake elements (image) that we use were treated by the browser as they were, even it's been displayed as block.
After 3.4, we introduced the contenteditable support, a nice substitution of fake elements in certain cases, the advantages include:
The patch propose an attempt in this approach.