Opened 6 years ago

Closed 5 years ago

#6684 closed Bug (fixed)

Toolbar isn't wrapped in Webkit when editor is in the table

Reported by: kresimir Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.5.1
Component: UI : Toolbar Version: 3.0
Keywords: WebKit Cc:

Description

When toolbar has many items (e.g. Full toolbar) and editor is placed in table which is in div block with fixed width, editor doesn't wrap toolbar in WebKit (Chrome and Safari) and puts whole toolbar in one line.

To reproduce this bug, add following around a form which has editor with full toolbar:

<div style="width: 400px; border: 1px solid red;"><table><tr><td>
</div>

Attachments (3)

jqueryadapter_table.html (3.1 KB) - added by kresimir 6 years ago.
Reproducing the bug with modifying ckeditor/_samples/jqueryadapter.html
6684.patch (1.0 KB) - added by garry.yao 5 years ago.
6684_2.patch (1.5 KB) - added by garry.yao 5 years ago.

Download all attachments as: .zip

Change History (11)

Changed 6 years ago by kresimir

Reproducing the bug with modifying ckeditor/_samples/jqueryadapter.html

Changed 5 years ago by garry.yao

comment:1 Changed 5 years ago by garry.yao

  • Component changed from General to UI : Toolbar
  • Milestone set to CKEditor 3.5.1
  • Owner set to garry.yao
  • Status changed from new to review
  • Version set to 3.0

Look serious, unless we come with a reason to keep that line.

comment:2 Changed 5 years ago by tobiasz.cudnik

  • Keywords WebKit added

comment:3 Changed 5 years ago by tobiasz.cudnik

Works good, but i'm not sure if we should remove inline-table for all browsers, when it creates issue only on Webkit.

Changed 5 years ago by garry.yao

comment:4 Changed 5 years ago by garry.yao

I've failed to check the original commits due the "lost" of the original kama branch, so please somebody remembers.

comment:5 follow-up: Changed 5 years ago by Saare

  • Status changed from review to review_failed

In Chrome, clicking on collapse toolbar button, the width of the editor decreases.

comment:6 in reply to: ↑ 5 Changed 5 years ago by garry.yao

  • Status changed from review_failed to review

Replying to Saare:

In Chrome, clicking on collapse toolbar button, the width of the editor decreases.

Quite unfortunate but AFAIK that's an existing bug.

comment:7 Changed 5 years ago by Saare

  • Status changed from review to review_passed

Indeed an existing bug, my bad.

comment:8 Changed 5 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [6304].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy