Opened 6 years ago

Closed 5 years ago

#6718 closed Bug (fixed)

paste from word command should dominate

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.5.4
Component: Core : Pasting Version: 3.1
Keywords: Cc: Thomas@…

Description

  1. Configure the editor with "forcePasteAsPlainText" set to true;
  2. Paste content from MS Word document with "Paste from Word" button;
  • Actual Result: Plain text are inserted;
  • Expected Result: Formatted text with proper word filtering are inserted.

Attachments (3)

6718.patch (652 bytes) - added by garry.yao 6 years ago.
6718_2.patch (1.2 KB) - added by garry.yao 5 years ago.
6718_3.patch (4.5 KB) - added by garry.yao 5 years ago.

Download all attachments as: .zip

Change History (13)

Changed 6 years ago by garry.yao

comment:1 Changed 6 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from new to review

comment:2 Changed 6 years ago by fredck

  • Milestone changed from CKEditor 3.5.1 to CKEditor 3.6

Being this a change on the behavior, I'm moving it to the 3.6.

We also need this exception documented on forcePasteAsPlainText, so people will be aware of it, not expecting plain text to be forced for the Paste from Word button as well.

comment:3 Changed 6 years ago by fredck

  • Status changed from review to review_failed

R- just for the missing documentation. I didn't check the code itself.

Changed 5 years ago by garry.yao

comment:4 Changed 5 years ago by garry.yao

  • Status changed from review_failed to review

comment:5 Changed 5 years ago by fredck

  • Status changed from review to review_failed

The patch forces the usage of the Paste dialog even when not needed, which is an unwanted behavior.

The Past from Word processing must happen in the exact same way, no matter the forcePasteAsPlainText setting.

Changed 5 years ago by garry.yao

comment:6 Changed 5 years ago by garry.yao

  • Status changed from review_failed to review

comment:7 follow-up: Changed 5 years ago by Saare

  • Status changed from review to review_failed

Pasting document from Word using CTRL+V (not the button) is still affected by forcePasteAsPlainText.

comment:8 in reply to: ↑ 7 Changed 5 years ago by fredck

Replying to Saare:

Pasting document from Word using CTRL+V (not the button) is still affected by forcePasteAsPlainText.

This behavior is ok Saare. This ticket is talking about the explicit action of using the Paste from Word button (or it's command).

Please put it on review again, Garry.

comment:9 Changed 5 years ago by Saare

  • Status changed from review_failed to review_passed

Sorry, I was unaware of that. Patch is good than.

comment:10 Changed 5 years ago by garry.yao

  • Milestone changed from CKEditor 3.6 to CKEditor 3.5.4
  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [6678] on trunk.

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy