Opened 14 years ago
Closed 14 years ago
#6718 closed Bug (fixed)
paste from word command should dominate
| Reported by: | Garry Yao | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.5.4 |
| Component: | Core : Pasting | Version: | 3.1 |
| Keywords: | Cc: | Thomas@… |
Description
- Configure the editor with "forcePasteAsPlainText" set to true;
- Paste content from MS Word document with "Paste from Word" button;
- Actual Result: Plain text are inserted;
- Expected Result: Formatted text with proper word filtering are inserted.
Attachments (3)
Change History (13)
Changed 14 years ago by
| Attachment: | 6718.patch added |
|---|
comment:1 Changed 14 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | new → review |
comment:2 Changed 14 years ago by
| Milestone: | CKEditor 3.5.1 → CKEditor 3.6 |
|---|
comment:3 Changed 14 years ago by
| Status: | review → review_failed |
|---|
R- just for the missing documentation. I didn't check the code itself.
Changed 14 years ago by
| Attachment: | 6718_2.patch added |
|---|
comment:4 Changed 14 years ago by
| Status: | review_failed → review |
|---|
comment:5 Changed 14 years ago by
| Status: | review → review_failed |
|---|
The patch forces the usage of the Paste dialog even when not needed, which is an unwanted behavior.
The Past from Word processing must happen in the exact same way, no matter the forcePasteAsPlainText setting.
Changed 14 years ago by
| Attachment: | 6718_3.patch added |
|---|
comment:6 Changed 14 years ago by
| Status: | review_failed → review |
|---|
comment:7 follow-up: 8 Changed 14 years ago by
| Status: | review → review_failed |
|---|
Pasting document from Word using CTRL+V (not the button) is still affected by forcePasteAsPlainText.
comment:8 Changed 14 years ago by
Replying to Saare:
Pasting document from Word using CTRL+V (not the button) is still affected by forcePasteAsPlainText.
This behavior is ok Saare. This ticket is talking about the explicit action of using the Paste from Word button (or it's command).
Please put it on review again, Garry.
comment:9 Changed 14 years ago by
| Status: | review_failed → review_passed |
|---|
Sorry, I was unaware of that. Patch is good than.
comment:10 Changed 14 years ago by
| Milestone: | CKEditor 3.6 → CKEditor 3.5.4 |
|---|---|
| Resolution: | → fixed |
| Status: | review_passed → closed |
Fixed with [6678] on trunk.
Being this a change on the behavior, I'm moving it to the 3.6.
We also need this exception documented on forcePasteAsPlainText, so people will be aware of it, not expecting plain text to be forced for the Paste from Word button as well.