Ticket #6753 (closed Bug: fixed)

Opened 3 years ago

Last modified 3 years ago

Cleanup core/editor class

Reported by: fredck Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.5.1
Component: General Version: 3.3
Keywords: Cc:

Description (last modified by fredck) (diff)

I can't believe it has been accepted, but plugin and theme dependent code has landed into the CKEDITOR.editor class with [5231].

Not even a single line that has been included there is acceptable. That code must be moved to the proper place.

Attachments

6753.patch (3.9 KB) - added by garry.yao 3 years ago.

Change History

Changed 3 years ago by garry.yao

comment:1 Changed 3 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from new to review

Assuming you mean [5231].

comment:2 follow-up: ↓ 4 Changed 3 years ago by tobiasz.cudnik

It look like R+ for me, but the code referenced in contextmenu is missing in current trunk. Does this change anything?

comment:3 Changed 3 years ago by fredck

  • Description modified (diff)

comment:4 in reply to: ↑ 2 Changed 3 years ago by Saare

  • Status changed from review to review_passed

Replying to tobiasz.cudnik:

the code referenced in contextmenu is missing in current trunk.

The piece of code you're refering to was removed with [5937] and it is no longer in any use.

comment:5 Changed 3 years ago by garry.yao

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [6307].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy