Ticket #6774 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

Default contents.css should provide only sample styles

Reported by: alfonsoml Owned by: alfonsoml
Priority: Normal Milestone: CKEditor 3.6
Component: General Version:
Keywords: Cc:

Description

Currently there are some internal rules added there that are lost as soon as the editor is integrated into any CMS and a new config.contentsCss is specified

html
{
	/* #3658: [IE6] Editor document has horizontal scrollbar on long lines
	To prevent this misbehavior, we show the scrollbar always */
	_overflow-y: scroll;
	/* #6341: The text cursor must be set on the editor area. */
	cursor: text;
	/* #6632: Avoid having "text" shape of cursor in IE7 scrollbars.*/
	*cursor:auto;
}

img:-moz-broken
{
	-moz-force-broken-image-icon : 1;
	width : 24px;
	height : 24px;
}
img, input, textarea
{
	cursor: default;
}

All these rules should be created inline by the plugins (and even included only for the correct browsers).

Attachments

6774.patch (1.8 KB) - added by alfonsoml 4 years ago.
Proposed patch

Change History

comment:1 Changed 4 years ago by garry.yao

  • Status changed from new to confirmed
  • Component changed from General to Core : Styles

Changed 4 years ago by alfonsoml

Proposed patch

comment:2 Changed 4 years ago by alfonsoml

  • Owner set to alfonsoml
  • Status changed from confirmed to review

comment:3 Changed 4 years ago by garry.yao

  • Status changed from review to review_failed

For me the rest of content.css are subjected to move.

comment:4 Changed 4 years ago by alfonsoml

  • Status changed from review_failed to review

If we remove the rest of the content.css then the provided samples would show up in Times New Roman unless we create a new "contentSample.css" file to put there some basic styles like the content.css file has now, so I don't see how that's related to the issue handled in this ticket.

comment:5 Changed 4 years ago by fredck

  • Status changed from review to review_passed
  • Component changed from Core : Styles to General
  • Milestone set to CKEditor 3.6

Please be sure to have it committed into the 3.6.x branch.

comment:6 Changed 4 years ago by alfonsoml

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [6685]

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy