Ticket #6835 (review_failed Bug)

Opened 4 years ago

Last modified 3 years ago

A few dialogs' content is not resiable

Reported by: Saare Owned by: Saare
Priority: Normal Milestone:
Component: UI : Dialogs Version: 3.5
Keywords: Discussion Cc:

Description

In a few dialog we have fixed width for content, so the dialog is resizable but the content size is never changed.
We need to make the content resizable (or cancel the resizing option of them).

  • Spell checker (covered by #6829).
  • Paste.
  • Special characters.
  • Select color.

Attachments

Dialog-Window-Resizing-Find-Replace.png (12.2 KB) - added by Anna 4 years ago.
Find and Replace dialog window with the resizing grip missing
6835.patch (5.0 KB) - added by Saare 4 years ago.
6835_ref.patch (2.8 KB) - added by garry.yao 4 years ago.
Patch enables vertical stretch in dialog

Change History

comment:1 Changed 4 years ago by garry.yao

  • Status changed from new to confirmed

Unfortunately for "specialchar" and "color picker" due to grid(table) layout, a liquid layout is never achievable.

comment:2 Changed 4 years ago by wwalc

  • Milestone changed from CKEditor 3.5 to CKEditor 3.5.1

Changed 4 years ago by Anna

Find and Replace dialog window with the resizing grip missing

comment:3 Changed 4 years ago by Anna

I don't know whether it's the same issue or not, but in v3.5 the Find and Replace dialog window is NOT resizable and does NOT contain the resizing grip icon.

comment:4 Changed 4 years ago by Saare

  • Status changed from confirmed to assigned
  • Owner set to Saare

Changed 4 years ago by Saare

comment:5 Changed 4 years ago by Saare

  • Status changed from assigned to review

The resizing of the find/replace dialog was disabled, but unless anyone objects, the patch enables the resizing of this dialog.

comment:6 Changed 4 years ago by garry.yao

  • Status changed from review to review_failed

[6217] has been a misleading start to having those resizing logic boomed inside dialog codes, my intention is to have an 'onResize' handler introduced for each field in which we place the resize logic.

Note there's also another problem that v-resize looks meaningless at the moment, as for now table height doesn't stretch. I think we'd have to make that happen also.

Changed 4 years ago by garry.yao

Patch enables vertical stretch in dialog

comment:7 Changed 4 years ago by garry.yao

  • Keywords Discussion added

A experimental patch to demonstrate vertical liquid layout, let's whether we could have it.

comment:8 Changed 4 years ago by Saare

  • Milestone changed from CKEditor 3.5.1 to CKEditor 3.5.2

comment:9 Changed 3 years ago by wwalc

  • Milestone CKEditor 3.5.3 deleted
Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy