BiDi buttons are not reflected when a change is done through a dialog

[Saare]

• Open a sample and create a div.
• Note that the toolbar icon shows LTR.
• Right click on the div, and choose edit div.
• Go to the advanced tab and choose the RTL from the Language Direction dropdown.
• Click OK.

Note that the toolbar icon shows LTR.

[Saare]

• There're missing fields now (language code & title) and we already have the css class field in the general tab.
• It's impossible to edit class names of the div through the general tab (maybe becuase the same field appears on both tabs).
• Note that ​the way we handle styles from the styles set is not treated.

[garry.yao]

This's just a temporary fix, we need to seek for a way of firing this event at element::setAttribute(s) level or even by "DOMAttrModified" event.

[Saare]

The div dialog was just an example, also affects other dialogs (e.g. link). Let's find a way to trigger the event on attribute modification in general.

[Saare]

My bad, the link dialog is not a good example as the buttons only care about block level elements (maybe a point of thought?). All in all, this is an R- as the patch doesn't work for me, anyway we should still seek for a more dynamic way.

[garry.yao]

Ok now a generic solution proposed.

[Saare]

Note that el.setAttribute( 'style', 'sthg' ) is not the same as el.setStyle( 'sthg', 'sthg' ), so we can't map setAttribute to setStyle in that sense.

[garry.yao]

I'd not go with style parsing approach to NOT bring a performance impacts.

[Saare]

• Trying to insert a table results in a js error.
• We should also consider removeAttribute and removeStyle.

[garry.yao]

Trying to insert a table results in a js error.

Cannot reproduce this issue.

TC added with [6474].

[garry.yao]

Fixed with [6478].