Ticket #6869 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

data-cke-nostyle disappears from source

Reported by: wwalc Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.5.1
Component: Core : Output Data Version: 3.5
Keywords: Cc:

Description

Using the code suggested here:

http://dev.ckeditor.com/ticket/6103#comment:30

switch to source mode and back.

Result:

My name is <span>%NAME%</span>

Note: data-cke-nostyle="1" is gone.

Attachments

6869.patch (597 bytes) - added by garry.yao 4 years ago.
6869_2.patch (2.3 KB) - added by garry.yao 4 years ago.

Change History

Changed 4 years ago by garry.yao

comment:1 Changed 4 years ago by garry.yao

  • Status changed from new to review
  • Owner set to garry.yao

comment:2 Changed 4 years ago by Saare

  • Status changed from review to review_failed

An edge case, but easily fixable: attributes whose name starts with "data-cke-nostyle" (e.g. "data-cke-nostyles") are not removed.

comment:3 Changed 4 years ago by fredck

  • Keywords Discussion added

We have some problems here:

  • Considering that this attribute is defined in a plugin, it would be bad to have a special case for it on core. We could have similar issues with other plugins.
  • It looks like "data-cke-nostyle" was a bad name for it, because we're leaving the "data-cke-" prefix to CKEditor internal stuff.

Based on the above, wouldn't it be better to have the "data-cke-nostyle" changed to something like "data-nostyle"?

I know this would break backwards compatibility, but considering that we have introduced it on our very last version, the impact may be low. It would be a way for us to fix the mistake we've done on the previous release.

comment:4 Changed 4 years ago by garry.yao

+1 for rename, impacts should be very small

comment:5 Changed 4 years ago by fredck

  • Keywords Discussion removed

Ok, so let's do it earlier than later.

Changed 4 years ago by garry.yao

comment:6 Changed 4 years ago by garry.yao

  • Status changed from review_failed to review

comment:7 Changed 4 years ago by tobiasz.cudnik

  • Status changed from review to review_passed

Watch out for a corrupted changelog entry.

comment:8 Changed 4 years ago by garry.yao

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [6308].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy