Opened 13 years ago

Closed 13 years ago

#6869 closed Bug (fixed)

data-cke-nostyle disappears from source

Reported by: Wiktor Walc Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.5.1
Component: Core : Output Data Version: 3.5
Keywords: Cc:

Description

Using the code suggested here:

http://dev.ckeditor.com/ticket/6103#comment:30

switch to source mode and back.

Result:

My name is <span>%NAME%</span>

Note: data-cke-nostyle="1" is gone.

Attachments (2)

6869.patch (597 bytes) - added by Garry Yao 13 years ago.
6869_2.patch (2.3 KB) - added by Garry Yao 13 years ago.

Download all attachments as: .zip

Change History (10)

Changed 13 years ago by Garry Yao

Attachment: 6869.patch added

comment:1 Changed 13 years ago by Garry Yao

Owner: set to Garry Yao
Status: newreview

comment:2 Changed 13 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

An edge case, but easily fixable: attributes whose name starts with "data-cke-nostyle" (e.g. "data-cke-nostyles") are not removed.

comment:3 Changed 13 years ago by Frederico Caldeira Knabben

Keywords: Discussion added

We have some problems here:

  • Considering that this attribute is defined in a plugin, it would be bad to have a special case for it on core. We could have similar issues with other plugins.
  • It looks like "data-cke-nostyle" was a bad name for it, because we're leaving the "data-cke-" prefix to CKEditor internal stuff.

Based on the above, wouldn't it be better to have the "data-cke-nostyle" changed to something like "data-nostyle"?

I know this would break backwards compatibility, but considering that we have introduced it on our very last version, the impact may be low. It would be a way for us to fix the mistake we've done on the previous release.

comment:4 Changed 13 years ago by Garry Yao

+1 for rename, impacts should be very small

comment:5 Changed 13 years ago by Frederico Caldeira Knabben

Keywords: Discussion removed

Ok, so let's do it earlier than later.

Changed 13 years ago by Garry Yao

Attachment: 6869_2.patch added

comment:6 Changed 13 years ago by Garry Yao

Status: review_failedreview

comment:7 Changed 13 years ago by Tobiasz Cudnik

Status: reviewreview_passed

Watch out for a corrupted changelog entry.

comment:8 Changed 13 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [6308].

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy