Ticket #6869 (closed Bug: fixed)
data-cke-nostyle disappears from source
| Reported by: | wwalc | Owned by: | garry.yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.5.1 |
| Component: | Core : Output Data | Version: | 3.5 |
| Keywords: | Cc: |
Description
Using the code suggested here:
http://dev.ckeditor.com/ticket/6103#comment:30
switch to source mode and back.
Result:
My name is <span>%NAME%</span>
Note: data-cke-nostyle="1" is gone.
Attachments
Change History
comment:2 Changed 2 years ago by Saare
- Status changed from review to review_failed
An edge case, but easily fixable: attributes whose name starts with "data-cke-nostyle" (e.g. "data-cke-nostyles") are not removed.
comment:3 Changed 2 years ago by fredck
- Keywords Discussion added
We have some problems here:
- Considering that this attribute is defined in a plugin, it would be bad to have a special case for it on core. We could have similar issues with other plugins.
- It looks like "data-cke-nostyle" was a bad name for it, because we're leaving the "data-cke-" prefix to CKEditor internal stuff.
Based on the above, wouldn't it be better to have the "data-cke-nostyle" changed to something like "data-nostyle"?
I know this would break backwards compatibility, but considering that we have introduced it on our very last version, the impact may be low. It would be a way for us to fix the mistake we've done on the previous release.
comment:5 Changed 2 years ago by fredck
- Keywords Discussion removed
Ok, so let's do it earlier than later.
Note: See
TracTickets for help on using
tickets.
