Table Dialog error when clicking OK button if multiple table cells are selected

[bshiver]

It is possible to get a "Uncaught TypeError: Cannot call method 'appendChild' of undefined" [Chrome] error ("k.$ is undefined" in Firefox) when clicking the OK button in the table dialog if the user selected multiple table cells before launching the table dialog. This bug affects all major browsers.

To reproduce:

1. Click the table dialog toolbar button and press the "Ok" button to insert a new table.
2. Select multiple cells in the new table by either clicking and dragging or Ctrl-clicking multiple cells.
3. Press the table dialog toolbar button again.
4. Press the "Ok" button in the table dialog.

Results:

If you check the console you will see the described error, and the Table Dialog will stay in open.

[Saare]

Not a 3.5 bug though; IIRC there's a ticket for that already but I can't find it.

[fredck]

I'm not able to reproduce it any more with trunk.

[j.swiderski]

This is still reproducible:

1. Clear editor contents.
2. Click the table dialog toolbar button and press the "Ok" button to insert a new table.
3. Fill table cells with sample text like "dd"
4. Select multiple cells in the new table by either clicking and dragging or Ctrl-clicking multiple cells.
5. Press the table dialog toolbar button again.
6. Press the "Ok" button in the table dialog.

Message: this.$ is undefined
Line: 201
URI: /trunk/_source/core/dom/element.js

[fredck]

My fault, I was using the context menu to open Table Properties.

The same thing happens if you click the "Insert Horizontal Line" button at step 5 of the above tc.

It is related to the insertion of elements over a multi-cells selections.

The right approach would be shrinking the selection to the cell touched by the start of the selection before proceeding with the insertion.