Opened 14 years ago
Closed 14 years ago
#6901 closed Bug (fixed)
Toolbar buttons are not changed for mixed content using shared spaces
| Reported by: | Sa'ar Zac Elias | Owned by: | Sa'ar Zac Elias |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.5.3 |
| Component: | Core : BiDi | Version: | 3.4 Beta |
| Keywords: | Cc: |
Description
Using shared spaces sample, change the paragraph's direction. Note that the toolbar buttons are not changed accordingly (#6041).
Attachments (4)
Change History (14)
comment:1 Changed 14 years ago by
| Status: | new → confirmed |
|---|---|
| Version: | → 3.4 Beta |
Changed 14 years ago by
| Attachment: | 6901.patch added |
|---|
comment:2 Changed 14 years ago by
| Owner: | set to Sa'ar Zac Elias |
|---|---|
| Status: | confirmed → review |
comment:3 Changed 14 years ago by
Could you attach a screenshot of the described issue? I'm having troubles with reproducing it in trunk using FF 3.6.13.
Changed 14 years ago by
comment:4 Changed 14 years ago by
| Milestone: | → CKEditor 3.5.2 |
|---|
comment:5 Changed 14 years ago by
| Status: | review → review_failed |
|---|
BID plugin should have no knowledge of shared space.
Changed 14 years ago by
| Attachment: | 6901_2.patch added |
|---|
comment:6 Changed 14 years ago by
| Status: | review_failed → review |
|---|
comment:7 Changed 14 years ago by
| Status: | review → review_failed |
|---|
Why not providing an "editor#contentDirChanged" event that consumed by theme and could be used by other plugins later.
Changed 14 years ago by
| Attachment: | 6901_3.patch added |
|---|
comment:8 Changed 14 years ago by
| Status: | review_failed → review |
|---|
comment:9 Changed 14 years ago by
| Status: | review → review_passed |
|---|
Guard over "directionNode " is unnecessary?
editor.fire( 'contentDirChanged', directionNode.getComputedStyle( 'direction' ));
comment:10 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [6429].
Note: See
TracTickets for help on using
tickets.
BIDI didn't take toolbar out into consideration.