Ticket #6901 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

Toolbar buttons are not changed for mixed content using shared spaces

Reported by: Saare Owned by: Saare
Priority: Normal Milestone: CKEditor 3.5.3
Component: Core : BiDi Version: 3.4 Beta
Keywords: Cc:

Description

Using shared spaces sample, change the paragraph's direction. Note that the toolbar buttons are not changed accordingly (#6041).

Attachments

6901.patch (1.0 KB) - added by Saare 4 years ago.
6901.PNG (20.8 KB) - added by Saare 4 years ago.
6901_2.patch (2.0 KB) - added by Saare 4 years ago.
6901_3.patch (2.1 KB) - added by Saare 4 years ago.

Change History

comment:1 Changed 4 years ago by garry.yao

  • Status changed from new to confirmed
  • Version set to 3.4 Beta

BIDI didn't take toolbar out into consideration.

Changed 4 years ago by Saare

comment:2 Changed 4 years ago by Saare

  • Status changed from confirmed to review
  • Owner set to Saare

comment:3 Changed 4 years ago by wwalc

Could you attach a screenshot of the described issue? I'm having troubles with reproducing it in trunk using FF 3.6.13.

Changed 4 years ago by Saare

comment:4 Changed 4 years ago by wwalc

  • Milestone set to CKEditor 3.5.2

comment:5 Changed 4 years ago by garry.yao

  • Status changed from review to review_failed

BID plugin should have no knowledge of shared space.

Changed 4 years ago by Saare

comment:6 Changed 4 years ago by Saare

  • Status changed from review_failed to review

comment:7 Changed 4 years ago by garry.yao

  • Status changed from review to review_failed

Why not providing an "editor#contentDirChanged" event that consumed by theme and could be used by other plugins later.

Changed 4 years ago by Saare

comment:8 Changed 4 years ago by Saare

  • Status changed from review_failed to review

comment:9 Changed 4 years ago by garry.yao

  • Status changed from review to review_passed

Guard over "directionNode " is unnecessary?

editor.fire( 'contentDirChanged', directionNode.getComputedStyle( 'direction' ));

comment:10 Changed 4 years ago by Saare

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [6429].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy