Ticket #6901 (closed Bug: fixed)
Toolbar buttons are not changed for mixed content using shared spaces
| Reported by: | Saare | Owned by: | Saare |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.5.3 |
| Component: | Core : BiDi | Version: | 3.4 Beta |
| Keywords: | Cc: |
Description
Using shared spaces sample, change the paragraph's direction. Note that the toolbar buttons are not changed accordingly (#6041).
Attachments
Change History
comment:1 Changed 2 years ago by garry.yao
- Status changed from new to confirmed
- Version set to 3.4 Beta
comment:3 Changed 2 years ago by wwalc
Could you attach a screenshot of the described issue? I'm having troubles with reproducing it in trunk using FF 3.6.13.
comment:5 Changed 2 years ago by garry.yao
- Status changed from review to review_failed
BID plugin should have no knowledge of shared space.
comment:7 Changed 2 years ago by garry.yao
- Status changed from review to review_failed
Why not providing an "editor#contentDirChanged" event that consumed by theme and could be used by other plugins later.
comment:9 Changed 2 years ago by garry.yao
- Status changed from review to review_passed
Guard over "directionNode " is unnecessary?
editor.fire( 'contentDirChanged', directionNode.getComputedStyle( 'direction' ));
comment:10 Changed 2 years ago by Saare
- Status changed from review_passed to closed
- Resolution set to fixed
Fixed with [6429].
Note: See
TracTickets for help on using
tickets.
BIDI didn't take toolbar out into consideration.