Opened 9 years ago

Closed 8 years ago

#692 closed Bug (fixed)

[SS] Some style definitions should be blocked in the combo

Reported by: deadmoroz@… Owned by: martinkou
Priority: Normal Milestone: FCKeditor 2.6.3
Component: Core : Styles Version:
Keywords: SF Confirmed Review+ Cc:

Description

When displaying styles available from fckstyles.xml in styles combo each option is being styled according to the style it belongs to.

But if the style has something like "padding-left" attribute, let's say 180px, then the option becomes invisible (the padding is applied to the combo's option as well and it's being displaced completely to the right).

It's needed to introduce some !important attributes for combo's options that couldn't be overriden by styles from fckstyles.xml


Moved from SF:
http://sourceforge.net/tracker/index.php?func=detail&aid=1392114&group_id=75348&atid=543653

Attachments (2)

692.patch (2.0 KB) - added by martinkou 8 years ago.
692_2.patch (2.5 KB) - added by martinkou 8 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 9 years ago by martinkou

  • Reporter changed from martinkou to deadmoroz@…

Marked it as [SS] (Style Selector).


Moved from SF. Original poster: fredck

comment:2 Changed 9 years ago by fredck

  • Cc fredck removed
  • Component changed from General to Core : Styles
  • Milestone set to FCKeditor 2.6

comment:3 Changed 9 years ago by w.olchawa

  • Keywords Confirmed added

comment:4 Changed 9 years ago by fredck

  • Keywords Discussion added
  • Milestone changed from FCKeditor 2.6 to FCKeditor 2.6.1

I was doing some tests with it. It could be "solved" by changing the following rule to the fck_editor.css skin file"

.SC_Item *, .SC_ItemSelected *
{
	margin: 0px !important;
	padding: 0px !important;
	text-indent: 0px !important;
	clip: auto !important;
	position: static !important;
}

But then, came to my mind that it may be important in some cases to leave some of those properties untouched for a proper and more realistic preview. For example, there could be a style that adds a border to the selection, with a small padding to it. If we remove the padding, the style could result ugly in the preview.

There is also another aspect to consider. Currently it is possible to "correct" it by adding the above CSS definition in the editing area stylesheet. So, it is already possible to a developer to fix those things if necessary.

I'm a bit unsure about the correct approach here. For now, I'm postponing it to the 2.6.1, so we can take the final decision later, maybe based on further discussion over it.

comment:5 Changed 9 years ago by martinkou

  • Owner set to martinkou
  • Status changed from new to assigned

comment:6 Changed 8 years ago by martinkou

After some discussion with Fred yesterday, it was decided that the style overrides are better done by the user instead of by us. However, we should leave some hints in the editor/css/fck_editorarea.css and in our documentation page so that our users will know how to handle that.

Changed 8 years ago by martinkou

comment:7 Changed 8 years ago by martinkou

  • Keywords Review? added; Discussion removed

comment:8 Changed 8 years ago by fredck

  • Keywords Review- added; Review? removed

The new comments look good.

If the comment style are to be fixed in lines 53-55, for consistency it should be done in all comments in that file. Otherwise, just use the style previously used.

Also, the comment style correction at line 53-55 left the comment closing not aligned at line 56.

Changed 8 years ago by martinkou

comment:9 Changed 8 years ago by martinkou

  • Keywords Review? added; Review- removed

comment:10 Changed 8 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:11 Changed 8 years ago by martinkou

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [2138].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy