Opened 5 years ago

Closed 4 years ago

#7158 closed Bug (fixed)

Image placeholder for inserting an iframe does not use the style attribute

Reported by: tmonahan Owned by: Saare
Priority: Normal Milestone: CKEditor 3.6.1
Component: UI : Dialogs Version: 3.5
Keywords: ibm iframe Cc: damo, satya, jamescun

Description

  1. Open any sample from the nightly build.
  1. Insert an iframe, specifying a width and height on the General tab and a style on the Advanced tab that sets the width and height properties to different values e.g

General tab: width = 300, height = 500

Advanced tab: style = width: 600px; height: 200px;

Problem: The image placeholder in the editor uses the width and height values from the General tab but if you preview the iframe it uses the width and height set in the style attribute.

The image placeholder should also use the style attribute to give the user an accurate representation of the size of the iframe.

Attachments (1)

7158.patch (2.4 KB) - added by Saare 4 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 5 years ago by garry.yao

  • Component changed from General to UI : Dialogs
  • Status changed from new to confirmed
  • Version set to 3.5

comment:2 Changed 4 years ago by Saare

  • Owner set to Saare
  • Status changed from confirmed to assigned

Changed 4 years ago by Saare

comment:3 Changed 4 years ago by Saare

  • Status changed from assigned to review

Proposing to have the fields synchronized.

comment:4 Changed 4 years ago by garry.yao

  • Status changed from review to review_passed

comment:5 Changed 4 years ago by fredck

  • Milestone set to CKEditor 3.6.1

comment:6 Changed 4 years ago by Saare

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [6958].

comment:7 Changed 4 years ago by tmonahan

We can still reproduce this issue in IE6 and IE7 - Can you please reopen this ticket to investigate further?

comment:8 Changed 4 years ago by tmonahan

We can still reproduce this issue on IE6, IE7 and IE8. To reproduce, enter width and height settings on the general tab, then switched to the advanced tab and change the width and height values. Remain on the Advanced tab and click OK. The placeholder image in the editor is not updated with the new width and height settings. Note: If you move back to the General tab before clicking OK, the placeholder size is updated correctly.

comment:9 Changed 4 years ago by wwalc

  • Resolution fixed deleted
  • Status changed from closed to reopened

Confirmed, there is also one more bug introduced with [6958]: #7981.

comment:10 Changed 4 years ago by Saare

  • Resolution set to fixed
  • Status changed from reopened to closed

Actually this is a different bug: #7933.

Note: See TracTickets for help on using tickets.
© 2003 – 2015 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy