Ticket #7294 (closed Bug: fixed)

Opened 3 years ago

Last modified 3 years ago

IE we can't convert Numbered list to a Bulleted list and vice versa

Reported by: satya Owned by: Saare
Priority: Normal Milestone: CKEditor 3.5.3
Component: General Version: 3.5.3
Keywords: IBM IE Cc: damo,jamescun,tmonahan

Description

To reproduce the defect

  1. Open CK Editor and type 2 paragraphs of text.
  1. select 2 paragraphs and click on Insert/Remove Numbered list button
  1. see that a Numbered list appears with 2 list items.
  1. Now select both list items and click on Insert/Remove Bulleted list button.

Expected Result:

Numbered list is converted to a Bulleted list.

Actual Result:

Nothing happens and we are seeing an error in IE and error says 'this.$currentStyle' is null or not an object.

same issue occurs when we try to convert a Bulleted list to a Numbered list.

Attachments

7294.patch (795 bytes) - added by Saare 3 years ago.
7294_2.patch (1.3 KB) - added by Saare 3 years ago.

Change History

comment:1 Changed 3 years ago by Saare

  • Status changed from new to confirmed
  • Version set to 3.5.3 (SVN - trunk)
  • Milestone set to CKEditor 3.5.3

Regression of [6478].

Changed 3 years ago by Saare

comment:2 Changed 3 years ago by Saare

  • Keywords IE added
  • Owner set to Saare
  • Status changed from confirmed to review

IE will generate an error when getting current styles from elements that are yet to be in the DOM tree.

comment:3 Changed 3 years ago by Saare

#7303 is a dup.

comment:4 Changed 3 years ago by garry.yao

  • Status changed from review to review_failed

"currentStyle" is not a cross-browser property.

Changed 3 years ago by Saare

comment:5 Changed 3 years ago by Saare

  • Status changed from review_failed to review

comment:6 Changed 3 years ago by Saare

Seems like the problem affects non-IEs as well in a different way, the latest patch fixes issues described in #7320, #7319.

comment:7 Changed 3 years ago by garry.yao

  • Status changed from review to review_passed

Instead of having "isInDoc( el, doc )" I think we could safely have "isOffline( el )".

comment:8 Changed 3 years ago by Saare

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [6551].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy