Ticket #7321 (closed Bug: fixed)

Opened 4 years ago

Last modified 3 years ago

IE6: Right borders missing in dialog textfields in RTL languages

Reported by: jamescun Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.6.1
Component: UI : Dialogs Version: 3.0
Keywords: IBM IE6 Cc: damo, satya, tmonahan

Description

Steps to reproduce the defect:

  1. Open the languages sample in IE6.
  1. Select a RTL language i.e. Arabic/Hebrew.
  1. Open the Table dialog.
  1. Click on the Advanced tab.

Result: See that the right border of the Style textfield is missing.

  1. Click into any of the other textfields & type some text.

Result: See that the right border is missing after entering text into a textfield (see screenshot).

  1. Click on the Table Properties tab.

Result: See that most of the right borders are missing.

Attachments

border missing issue.jpg (17.7 KB) - added by jamescun 4 years ago.
7321.patch (1.4 KB) - added by Saare 4 years ago.
borders missing.jpg (26.5 KB) - added by satya 4 years ago.
7321_2.patch (1.8 KB) - added by garry.yao 3 years ago.
ckeditor_borders_rtl.png (15.3 KB) - added by wwalc 3 years ago.
ckeditor_borders.png (8.9 KB) - added by wwalc 3 years ago.
7321_3.patch (1.7 KB) - added by garry.yao 3 years ago.
ckeditor_ie8_quirks_patch3.png (11.4 KB) - added by wwalc 3 years ago.

Change History

Changed 4 years ago by jamescun

comment:1 Changed 4 years ago by jamescun

This issue is also present in IE7 Quirks mode and IE8 Quirks mode.

comment:2 Changed 4 years ago by krst

  • Status changed from new to confirmed
  • Version changed from 3.5.3 (SVN - trunk) to 3.0

Occurs in all dialogs since v3.0 in RTL languages

comment:3 Changed 4 years ago by Saare

  • Owner set to Saare
  • Status changed from confirmed to assigned

Changed 4 years ago by Saare

comment:4 Changed 4 years ago by Saare

  • Status changed from assigned to review

comment:5 Changed 4 years ago by fredck

  • Status changed from review to review_failed

I see no changes after patch.

Btw, this issue (very similar, actually) can be verified with IE9+Quirks also.

comment:6 Changed 4 years ago by fredck

  • Status changed from review_failed to review_passed

Ops... I did something wrong. Nice job!

comment:7 Changed 4 years ago by fredck

  • Milestone set to CKEditor 3.6.1

comment:8 Changed 4 years ago by Saare

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [6937].

comment:9 follow-up: ↓ 10 Changed 4 years ago by satya

I could still see the borders missing on nightly build. Please re open the ticket. i have attached a screenshot.

Changed 4 years ago by satya

comment:10 in reply to: ↑ 9 Changed 3 years ago by krst

Replying to satya:

I could still see the borders missing on nightly build. Please re open the ticket. i have attached a screenshot.

I agree. Checked with CKEditor r7013

comment:11 Changed 3 years ago by fredck

  • Status changed from closed to reopened
  • Resolution fixed deleted

Changed 3 years ago by garry.yao

comment:12 Changed 3 years ago by garry.yao

  • Owner changed from Saare to garry.yao
  • Status changed from reopened to review

comment:13 Changed 3 years ago by wwalc

Though not 100% related with the original TC, I still see some problems in IE6:

  • in the Image dialog in LTR language (right borders are missing)

  • in RTL mode, Image dialog, in the "Advanced" tab (left border is missing)

Last edited 3 years ago by wwalc (previous) (diff)

Changed 3 years ago by wwalc

Changed 3 years ago by wwalc

Changed 3 years ago by garry.yao

Changed 3 years ago by wwalc

comment:14 Changed 3 years ago by wwalc

The third patch caused that IE8 in Quirks mode not does not render input fields correctly in LTR mode (they used to take all the available space, now it looks less nice).

If I had to choose whether to:

  1. render borders for all fields in IE6 (with 7321_3.patch) for the price of shortening significantly input fields in LTR mode
  2. or live with the issue that I described for LTR language (right border is mising in IE6) while keeping current length of input elements,

I'd choose the second option. In other words, the third patch is not right imho, the Image dialog should not look like in the image below:

If there's no way to fix the things that I mentioned, let's just focus on the original TC and stay with the second patch.

comment:15 Changed 3 years ago by Saare

  • Status changed from review to review_passed

Ok.. r+ for the 7321_2.patch.. it's ugly though :/

Last edited 3 years ago by Saare (previous) (diff)

comment:16 Changed 3 years ago by garry.yao

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [7031].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy