Ticket #7616 (confirmed New Feature)

Opened 3 years ago

Last modified 13 months ago

Support window name in the popup plugin

Reported by: shyrkov Owned by:
Priority: Normal Milestone:
Component: File Browser Version: 3.0
Keywords: Cc:

Description

With the following changes the popup plugin was extended with window features, but it is still impossible to specify the popup windowName. It would be nice to add support for it, otherwise the file browser is opened in a new window each time (even if the corresponding window is already opened).

The popup function in the CKEditor/trunk/_source/plugins/popup/plugin.js can be adjsuted to accept windowName:

popup : function( url, width, height, options, windowName )

Thank you in advance!

Attachments

ckeditor-7616.patch (2.4 KB) - added by shyrkov 3 years ago.
Attached the patch (ckeditor-7616.patch) against current trunk (last revision was 6829)

Change History

Changed 3 years ago by shyrkov

Attached the patch (ckeditor-7616.patch) against current trunk (last revision was 6829)

comment:1 follow-up: ↓ 2 Changed 13 months ago by j.swiderski

  • Status changed from new to confirmed
  • Keywords popup windowName removed
  • Version set to 3.0
  • Component changed from General to File Browser

I have tried your code in latest CKEditor 4.2 with CKFinder 2.4. The result wasn't as expected. On second Browse Server button click the popup was closed. Something like this doesn't happen with native code (I have checked to make sure).

Never the less you are right users should have the choice whether they want to open new window on every button click or want just one window opened. Providing name for popup window as config option should allow that and will override default "_blank" setting.

comment:2 in reply to: ↑ 1 Changed 13 months ago by shyrkov

Thank you for the feedback Jakub! The patch was submitted by me more than 2 years ago against trunk, which at that time was 3.x. I doubt the original patch is compatible with the CKEditor 4.x.

Replying to j.swiderski:

I have tried your code in latest CKEditor 4.2 with CKFinder 2.4. The result wasn't as expected. On second Browse Server button click the popup was closed. Something like this doesn't happen with native code (I have checked to make sure).

Never the less you are right users should have the choice whether they want to open new window on every button click or want just one window opened. Providing name for popup window as config option should allow that and will override default "_blank" setting.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy