execCommand throws an error when data is empty

[alan]

i think it would be a good idea to check (if is empty) data before call execCommand.

For example in _source/ywsiwygarea/plugin.js in line 55-56

if ( this.dataProcessor )

data = this.dataProcessor.toHtml( data );

there might be some JS errors since we use our own dataprocessor which can result in data being empty. So for avoiding this i think it would be nice to check if data is empty or something like that before calling execCommand.

Alan Orduno

[Jakub Ś]

The default version of htmlDataProcessor always returns at least empty string for data so that it never is empty.

Perhaps a better option would be to modify your dataprocessor to always return something in data.

[Frederico Caldeira Knabben]

Basically, toHtml() is *required* to always return a HTML string, even if empty.

[Freddie Bingham]

"empty string for data so that it never is empty"

I am confused. An empty string is not empty? I am not talking null values here but a valid empty string.

Our dataprocessor always returns a string, albeit an empty string sometimes. Why do you say that an empty string is acceptable when execCommand will not accept an empty string on IE?

[Frederico Caldeira Knabben]

I'm also very confused here... you're talking about execCommand, but then you pointed us to dataProcessor.toHtml... can you please be more precise about what execCommand call you're talking about?

[Freddie Bingham]

function doInsertHtml( data )

The execCommand around line 106 in wysiwygarea/plugin.php .. where the data that is set at the beginning of this function ultimately ends up. This gets executed for NON IE and it throws an error when data is an empty string.

[Frederico Caldeira Knabben]

Ah, ok... now it's much clearer.

Is the attached patch the kind of fix you're talking about?

[Freddie Bingham]

Yes, that would work nicely.

[Frederico Caldeira Knabben]

Fixed with [6973].