#7811 closed Bug (fixed)
[IE] Delete row throws JS error
| Reported by: | Garry Yao | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.6.1 |
| Component: | General | Version: | 3.5.1 |
| Keywords: | IE IBM | Cc: | satya_minnekanti@… |
Description (last modified by )
Applies to IE<=8, delete table row now throws error, even though cursor position looks right, regression of [6328].
Attachments (2)
Change History (15)
comment:1 Changed 13 years ago by
| Description: | modified (diff) |
|---|---|
| Milestone: | CKEditor 3.6 |
| Status: | new → confirmed |
| Version: | 3.6 (SVN - 3.6.x) → 3.5.1 |
Changed 13 years ago by
| Attachment: | 7811.patch added |
|---|
comment:2 Changed 13 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | confirmed → review |
comment:3 Changed 13 years ago by
| Cc: | satya_minnekanti@… added |
|---|
comment:4 Changed 13 years ago by
| Status: | review → review_failed |
|---|
Changed 13 years ago by
| Attachment: | 7811_2.patch added |
|---|
comment:5 Changed 13 years ago by
| Status: | review_failed → review |
|---|
comment:6 Changed 13 years ago by
| Status: | review → review_passed |
|---|
I feel that the proper fix would be something in between those two patches.
When deleting the row, I expect the cursor to jump to the *next* row. That happened with the first patch. With the second one, it's now jumping to the *previous* row, which is wrong.
Please review the behavior on commit.
comment:7 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [6874].
comment:8 Changed 13 years ago by
| Milestone: | → CKEditor 3.6.1 |
|---|---|
| Resolution: | fixed |
| Status: | closed → reopened |
Let's avoid introducing last minute changes when the second testing phase is about to finish. Even if it's a simple change it needs to be tested well.
comment:10 Changed 13 years ago by
I'm sorry for having targeted it wrongly. I really though it was a 3.6 issue, since the beginning. Only after commit I saw it is an older issue. Well done, wwalc.
comment:11 Changed 13 years ago by
| Keywords: | IBM added |
|---|
After patch, there is a buggy effect if you delete the last available row in a table. A cell-less table remains.