Ticket #7844 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

FF: setData() on hidden editor causes editor not to display

Reported by: damo Owned by: Saare
Priority: Normal Milestone: CKEditor 3.6.1
Component: General Version: 3.4.1
Keywords: IBM Firefox Cc:

Description

This problem happens on FF and when the instance is created with CKEDITOR.appendTo().

When the editor's container is hidden and setData() is called on it, making the container visible does not make the editor instance visible.

The problem appears to be related to the following in wysiwygarea plugin.js:

if ( isHidden )
{
	setTimeout( function()
	{
		element.hide();
		element.setStyles( previousStyles );
	}, 1000 );
}

A sample test page has been attached also.

Attachments

7844.html (1.5 KB) - added by damo 4 years ago.
Test case
7844.patch (1.1 KB) - added by Saare 4 years ago.
7844_5956.html (1.7 KB) - added by Saare 4 years ago.

Change History

Changed 4 years ago by damo

Test case

comment:1 Changed 4 years ago by j.swiderski

  • Status changed from new to confirmed
  • Keywords Firefox added
  • Version changed from 3.5.2 to 3.4.1

True for Firefox browsers from CKEditor 3.4.1

Changed 4 years ago by Saare

comment:2 Changed 4 years ago by Saare

  • Owner set to Saare
  • Status changed from confirmed to review

Seems like [5835] from #5956 is no longer needed.

comment:3 Changed 4 years ago by damo

Has this patch been verified?

Changed 4 years ago by Saare

comment:4 Changed 4 years ago by Saare

Attached is a TC for both this ticket and #5956.

comment:5 Changed 4 years ago by fredck

  • Status changed from review to review_passed

As for #5956, I've just tested it with Firefox 3.6.16 and it works well. I'm happy to remove that hack from the code.

comment:6 Changed 4 years ago by fredck

  • Milestone set to CKEditor 3.6.1

comment:7 Changed 4 years ago by Saare

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [6934].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy