Ticket #7886 (review_failed Bug)

Opened 4 years ago

Last modified 3 years ago

Show border plugin + custom table dialog

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone:
Component: UI : Dialogs Version: 3.1
Keywords: Cc:

Description

The "showborders" makes assumption on existence of certain table dialog field thus get broken when table dialog definition is reduced.

Attachments

7886.html (3.4 KB) - added by garry.yao 4 years ago.
Reproducing sample page
7886.patch (3.9 KB) - added by garry.yao 4 years ago.

Change History

Changed 4 years ago by garry.yao

Reproducing sample page

comment:1 Changed 4 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from new to review

Changed 4 years ago by garry.yao

comment:2 Changed 3 years ago by Saare

  • Status changed from review to review_failed

The patch needs to be updated. Also, while at it, let's consider CSS borders. (And a small enhancement: the bidi plugin contains isOffline method, let's change it as well if adding it to dom.element).

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy