Opened 14 years ago
Closed 14 years ago
#7914 closed Bug (fixed)
setReadOnly does the reverse of what it says it does
| Reported by: | Joe | Owned by: | Frederico Caldeira Knabben |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.6.1 |
| Component: | General | Version: | 3.6 |
| Keywords: | Cc: |
Description
Descriptive summary :
According to http://ckeditor.com/blog/CKEditor_3.6_released , editor.setReadOnly( true ) should turn Read Only mode on, while editor.setReadOnly( false ) sould turn Read Only mode off. In practice, its switched.
Steps to reproduce :
- Go to http://nightly.ckeditor.com/6956/_samples/readonly.html in Chrome
- Right click inspect to get to your console window
- In the console, type: editor.setReadOnly( true )
- Verify that the editor is not in read only mode
- In the console, type: editor.setReadOnly( false )
- Verify that the editor is in read only mode
Browser name and OS :
Chrome, Windows XP
Screenshot :
Attachments (2)
Change History (6)
Changed 14 years ago by
| Attachment: | 2011-05-24_1621.png added |
|---|
comment:1 Changed 14 years ago by
| Owner: | set to Frederico Caldeira Knabben |
|---|---|
| Status: | new → assigned |
The fact is that the release page example is the way it *should* be... but unfortunately a counter-intuitive way for it landed on the case, were "true" makes it editable.
I know we should not do that, but in this case we need to fix the API signature to make it work on the naturally expected way.
Changed 14 years ago by
| Attachment: | 7914.patch added |
|---|
comment:2 Changed 14 years ago by
| Status: | assigned → review |
|---|
comment:3 Changed 14 years ago by
| Milestone: | → CKEditor 3.6.1 |
|---|---|
| Status: | review → review_passed |
| Version: | → 3.6 |
Be sure to change the name of the parameter of the sample's toggleReadOnly function as well.
comment:4 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [6965].
screenshot