Opened 10 years ago

Closed 10 years ago

#802 closed Bug (fixed)

Replace bug in editor

Reported by: anonymous Owned by: martinkou
Priority: Normal Milestone:
Component: General Version:
Keywords: SF Cc:

Description (last modified by martinkou)

when using the replace function there is a strange fenominon.

when you enter a word and a word to replace, click on replace without selecting any other fields.

click replace again, the same section is always targetted...


Type in editor


Now search and replace oor by koor ....

Click on replace, then replace, then replace

The system will keep changing the first word and will not continue to the next one like (I think) it's supposed to

thank in advance

Moved from SF:

Change History (5)

comment:1 Changed 10 years ago by martinkou

  • Description modified (diff)
  • Reporter changed from martinkou to anonymous

comment:2 Changed 10 years ago by martinkou

  • Owner set to martinkou
  • Status changed from new to assigned

The current replace algorithm works by simply scanning from the beginning of the document in a depth first search. So, in your oor -> koor test case, the algorithm would keep replacing the "oor" in the newly generated "koor" strings.

The replace function in FCKeditor can be made more similar to that in MS Word by remembering the last replace position, for replace operations happening in the same replace dialog.

comment:3 Changed 10 years ago by martinkou

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [408].

Click here for more info about our SVN system.

comment:4 Changed 10 years ago by martinkou

  • Resolution fixed deleted
  • Status changed from closed to reopened

Oops... It is only working in Firefox, it's not working in Internet Explorer or Opera yet. Ticket reopened.

comment:5 Changed 10 years ago by martinkou

  • Resolution set to fixed
  • Status changed from reopened to closed

With changeset [410], the new replace code is now compatible with Internet Explorer and Opera.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy